On Tue, 2020-02-25 at 18:55 +0100, Marek Vasut wrote:
On 2/24/20 3:26 AM, Ang, Chee Hong wrote: On 2/21/20 7:15 PM, Ang, Chee Hong wrote: On 2/20/20 6:04 PM, Westergreen, Dalon wrote: Please fix your mailer, it makes your reply completely unreadable. On Thu, 2020-02-20 at 17:44 +0100, Marek Vasut wrote: On 2/20/20 3:12 AM, Ang, Chee Hong wrote: On 2/19/20 1:25 PM, <mailto: <mailto:chee.hong....@intel.com> chee.hong....@intel.com > <mailto:chee.hong....@intel.com> chee.hong....@intel.com wrote: From: Chee Hong Ang < <mailto: <mailto:chee.hong....@intel.com> chee.hong....@intel.com > <mailto:chee.hong....@intel.com> chee.hong....@intel.com CONFIG_OF_EMBED was primarily enabled to support the agilex spl hex file requirements. Since this option now produces a warning during build, and the spl hex can be created using alternate methods, CONFIG_OF_EMBED is no longer needed. OK, so this patch removes functionality. Can that functionality be retained ? Or what can be done here? The functionality is no longer required. Because you always depend on ATF now ? No. We have 2 different defconfigs in the patchset, one use ATF one without ATF. Both no longer using CONFIG_OF_EMBED and they worked fine. OK. So how is the .hex file generated now ? In our tree the patch i submitted to generate the hex file via objcopy is being used. I can resubmit this? Otherwise, people are just manually calling objcopy to convert the cat'ed spl-dtb.bin to a hex file offset to the appropriate address. --dalon
