On Fri, Feb 21, 2020 at 06:04:51PM +0100, Marek Vasut wrote: > On 2/21/20 6:01 PM, Tom Rini wrote: > > On Fri, Feb 21, 2020 at 05:18:09PM +0100, Marek Vasut wrote: > >> On 2/21/20 3:54 PM, Lukasz Majewski wrote: > >>> Dear Marek, > >> > >> Hi, > >> > >>> The following changes since commit > >>> f2a73d6867ef973fbb8471cc87058205999b5e5c: > >>> > >>> Merge tag 'u-boot-stm32-20200214' of > >>> https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2020-02-14 > >>> 07:31:47 -0500) > >>> > >>> are available in the Git repository at: > >>> > >>> g...@gitlab.denx.de:u-boot/custodians/u-boot-dfu.git > >> > >> This should be git:// or https:// URI here. > >> > >>> for you to fetch changes up to eb38f3703c5d0bc8a84db4d513ad220ce4f78f01: > >>> > >>> gadget: f_thor: add missing line breaks for pr_err() (2020-02-21 > >>> 10:22:38 +0100) > >>> > >>> ---------------------------------------------------------------- > >>> Andy Shevchenko (1): > >>> dfu: Reset timeout in case of DFU request > >>> > >>> Seung-Woo Kim (1): > >>> gadget: f_thor: add missing line breaks for pr_err() > >>> > >>> drivers/usb/gadget/f_dfu.c | 5 +++++ > >>> drivers/usb/gadget/f_thor.c | 24 ++++++++++++------------ > >>> 2 files changed, 17 insertions(+), 12 deletions(-) > >>> > >>> > >>> BRANCH: master > >> > >> Can you please add this information -- which branch to pull -- to > >> $subject ? It took me a long time to notice this important piece of > >> information, because it was buried somewhere in a wall of text down below. > >> > >>> https://gitlab.denx.de/u-boot/custodians/u-boot-dfu/commits/master > >>> > >>> Merge tag info: > >>> - Thor gadget pr_err() formatting change (adding trailing '\n' char) > >>> - Reset timeout when new DFU request is received. This prevents from > >>> rebooting the device when in the middle of long update process. > >>> > >>> Marek, please regard those two patches as FIXES. > > > > The general format is to say the URI and tag to pull (after the "are > > available in the Git repository at:" line), and have that tag contain > > the above info in it. > > ... assuming the repo uses tags. But branch is fine by me and it works > much faster for me if I see which branch I should pull right away.
And tags are strongly encouraged. If it's not a tag but a branch the branch should still be right there after the URI. But please use tags and provide a summary. We've long had demand for "what changed in this release?" and tags with summaries means that "git log --merges TAG1..TAG2" produces useful information for that. Thanks! -- Tom
signature.asc
Description: PGP signature
