Am 20.02.2020 um 17:45 schrieb Marek Vasut: > On 2/20/20 3:15 AM, Ang, Chee Hong wrote: >>> On 2/19/20 1:25 PM, chee.hong....@intel.com wrote: >>>> From: Chee Hong Ang <chee.hong....@intel.com> >>>> >>>> SPL now loads ATF (BL31), U-Boot proper and DTB from FIT image. The >>>> new boot flow with ATF support is as follow: >>>> >>>> SPL -> ATF (BL31) -> U-Boot proper -> OS (Linux) >>>> >>>> Signed-off-by: Chee Hong Ang <chee.hong....@intel.com> >>>> --- >>>> configs/socfpga_agilex_defconfig | 8 +++++++- >>>> configs/socfpga_stratix10_defconfig | 8 +++++++- >>>> 2 files changed, 14 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/configs/socfpga_agilex_defconfig >>>> b/configs/socfpga_agilex_defconfig >>>> index 693a774..0065ff0 100644 >>>> --- a/configs/socfpga_agilex_defconfig >>>> +++ b/configs/socfpga_agilex_defconfig >>>> @@ -1,6 +1,6 @@ >>>> CONFIG_ARM=y >>>> CONFIG_ARCH_SOCFPGA=y >>>> -CONFIG_SYS_TEXT_BASE=0x1000 >>>> +CONFIG_SYS_TEXT_BASE=0x200000 >>> >>> Why did the text base change ? >> This defconfig support ATF. >> ATF will occupy from this address range (0x1000) >> U-Boot now starts at 0x200000. > > Then please document it in the commit message.
Or even better, could we have 2 defconfigs, one for ATF, one for non-ATF? That way, we get build coverage that this still works. Regards, Simon > >>>> CONFIG_SYS_MALLOC_F_LEN=0x2000 >>>> CONFIG_ENV_SIZE=0x1000 >>>> CONFIG_ENV_OFFSET=0x200 >>>> @@ -10,10 +10,16 @@ CONFIG_TARGET_SOCFPGA_AGILEX_SOCDK=y >>>> CONFIG_IDENT_STRING="socfpga_agilex" >>>> CONFIG_SPL_FS_FAT=y >>>> CONFIG_SPL_TEXT_BASE=0xFFE00000 >>>> +CONFIG_FIT=y >>>> +CONFIG_SPL_LOAD_FIT=y >>>> +CONFIG_SPL_FIT_SOURCE="board/altera/soc64/its/fit_spl_atf.its" >>>> CONFIG_BOOTDELAY=5 >>>> +CONFIG_SPL_LEGACY_IMAGE_SUPPORT=y >>> >>> Is legacy image support really needed ? >> Let me check. Will get rid of this if it's not needed. Thanks. > > Thanks >
