On 17/02/20 9:16 am, Lokesh Vutla wrote:
>
>
> On 13/02/20 7:04 PM, moseschristoph...@gmail.com wrote:
>> From: Moses Christopher Bollavarapu <moseschristoph...@gmail.com>
>>
>> - As tiny printf lib is further optimized, the ability to deal with
>> ethaddr is lost. Hence, in order to handle usb-eth boot from SPL
>> we need to disable tiny printf.
>>
>> - Tested on Beagle Bone Black
>>
>> Signed-off-by: Moses Christopher Bollavarapu <moseschristoph...@gmail.com>
>
> This significantly increases the code size. Did you check how much is
> increased?
> SPL_TINY PRINTF is enabled on am335x_evm_defconfig to reduce the code size.
> Wondering what allowed to be built even after disabling tiny printf.
>
I agree with Lokesh. Fix should be to revert the change that broke tiny
printf as its breaks an already supported feature. Disabling
SPL_TINY_PRINTF bloats AM335x SPL image size which is already at limit.
Regards
Vignesh
