On Wed, Feb 12, 2020 at 06:14:49PM +0100, Heinrich Schuchardt wrote: > On 2/5/20 6:55 PM, s...@google.com wrote: > > When recording the console output for testing it is useful to be able to > > read the output a line at a time to check that the output is correct. Also > > we need to check that we get to the end of the output. > > > > Add a console function to return the next line and another to see how must > > data is left. > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > --- > > > > common/console.c | 11 +++++++++++ > > include/console.h | 19 +++++++++++++++++++ > > 2 files changed, 30 insertions(+) > > > > Applied to u-boot-dm, thanks! > > > > With this merged patch U-Boot does not compile: > > common/console.c:629:26: error: passing argument 1 of ‘membuff_readline’ > discards ‘volatile’ qualifier from pointer target type > [-Werror=discarded-qualifiers] > 629 | return membuff_readline(&gd->console_out, str, maxlen, ' '); > | ^~~~~~~~~~~~~~~~ > In file included from include/asm-generic/global_data.h:24, > from ./arch/arm/include/asm/global_data.h:87, > from include/common.h:36, > from common/console.c:7:
... with gcc-9.x I assume. We really do need to extend the CI loops to cover this someway or another, at least for Sandbox like with do with clang. Or maybe even just a newer clang would also catch it? It looks like an "easy" path forward here to test at least is to switch from LLVM-7 to LLVM-10. I'll fire off a travis test now and see what happens. -- Tom
signature.asc
Description: PGP signature
