Hi, > From: Wolfgang Denk <w...@denx.de> > Sent: vendredi 24 janvier 2020 14:20 > > Dear Patrick, > > In message <20200124124142.392-1-patrick.delau...@st.com> you wrote: > > > > +/* allows to set ext4 interface */ > > +const char *env_ext4_get_intf(void); > > Are you sure these comments are correct? > > A "get interface" function is not supposed to set anything? > > > +/* allows to set ext4 device and partition */ const char > > +*env_ext4_get_dev_part(void); > > A "get device and partition" function is not supposed to set anything?
Yes, I will update the comment. > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A > Puritan is someone who is deathly afraid that someone, somewhere, is having > fun. Thanks, Patrick