Hi Vignesh, On Mon, Jan 13, 2020 at 12:57 PM Kuldeep Singh <kuldeep.si...@nxp.com> wrote: > > This entire patch series migrate freescale qspi driver to spi-mem > framework. > > v4 version of series include removal of buildman failure on LS2080AQDS > build which was observed in cleanup patches. Also, more clear commit > message of patch 5. > > v3 version of series includes correction of copyright in qspi driver and > also move SPI_FLASH_SPANSION from header to defconfigs in same patch. > > v2 version of series includes changes in qspi driver to have 1k size > instead of complete flash size so as to make driver independent of flash > size. This also makes it align with linux version of driver. Also added > support for imx platforms to set TDH bits correctly. There are other minor > changes in commit messages. > > Dependency on patches[1][2]. These patches are required to resolve booting > crash observed in LS1012ARDB. One crash was related to pfe driver as it was > accessing flash memory directly and other was based on environment. > [1] https://patchwork.ozlabs.org/patch/1219462/ > [2] https://patchwork.ozlabs.org/patch/1208299/ > > Patch 1 adds new qspi driver incorporating spi-mem framework and also > removal of old driver which was based on spi-nor. The driver is a ported > version of linux qspi driver. Initial port was done by Frieder. Now, no > more direct memory access to spi-nor memory is possible i.e accessing flash > memory using absolute address is not possible. > > Patch 2 removes unused qspi config options. > > Patch 3 moves FSL_QSPI to defconfig instead of defining it in header files. > > Patch 4 removes unused num-cs property from imx platforms. > > Patch 5 enables SPI_FLASH_SPANSION in ls1012a defconfig as FSL_QSPI is > already enabled. > > Patch 6 enables SPI_FLASH_SPANSION in defconfigs of LS1046a boards instead > of defining in header files. > > Patch 7 updates the device-tree properties treewide for layerscape boards > by aligning with linux device-tree properties. > > Frieder Schrempf (1): > imx: imx6sx: Remove unused 'num-cs' property > > Kuldeep Singh (6): > spi: Transform the FSL QuadSPI driver to use the SPI MEM API > treewide: Remove unused FSL QSPI config options > configs: ls1043a: Move CONFIG_FSL_QSPI to defconfig > configs: ls1012a: Enable CONFIG_SPI_FLASH_SPANSION in defconfigs > configs: ls1046a: Move SPI_FLASH_SPANSION to defconfig > treewide: Update fsl qspi node dt properties as per spi-mem driver > > arch/arm/dts/fsl-ls1012a-2g5rdb.dts | 5 +- > arch/arm/dts/fsl-ls1012a-frdm.dtsi | 5 +- > arch/arm/dts/fsl-ls1012a-qds.dtsi | 5 +- > arch/arm/dts/fsl-ls1012a-rdb.dtsi | 5 +- > arch/arm/dts/fsl-ls1012a.dtsi | 4 +- > arch/arm/dts/fsl-ls1043a-qds.dtsi | 5 +- > arch/arm/dts/fsl-ls1043a.dtsi | 6 +- > arch/arm/dts/fsl-ls1046a-frwy.dts | 5 +- > arch/arm/dts/fsl-ls1046a-qds.dtsi | 5 +- > arch/arm/dts/fsl-ls1046a-rdb.dts | 5 +- > arch/arm/dts/fsl-ls1046a.dtsi | 4 +- > arch/arm/dts/fsl-ls1088a-qds.dts | 5 +- > arch/arm/dts/fsl-ls1088a-rdb.dts | 5 +- > arch/arm/dts/fsl-ls1088a.dtsi | 2 +- > arch/arm/dts/fsl-ls2080a-qds.dts | 5 +- > arch/arm/dts/fsl-ls2080a.dtsi | 4 +- > arch/arm/dts/fsl-ls2088a-rdb-qspi.dts | 5 +- > arch/arm/dts/imx6sx-sabreauto-u-boot.dtsi | 2 - > arch/arm/dts/imx6sx-sdb-u-boot.dtsi | 2 - > arch/arm/dts/ls1021a-twr.dtsi | 5 +- > arch/arm/dts/ls1021a.dtsi | 6 +- > arch/arm/include/asm/arch-fsl-layerscape/config.h | 1 - > arch/arm/include/asm/arch-ls102xa/config.h | 1 - > configs/ls1012a2g5rdb_qspi_defconfig | 1 + > configs/ls1012a2g5rdb_tfa_defconfig | 1 + > configs/ls1012afrdm_qspi_defconfig | 1 + > configs/ls1012afrdm_tfa_defconfig | 1 + > configs/ls1012aqds_qspi_defconfig | 1 + > configs/ls1012aqds_tfa_SECURE_BOOT_defconfig | 1 + > configs/ls1012aqds_tfa_defconfig | 1 + > configs/ls1012ardb_qspi_SECURE_BOOT_defconfig | 1 + > configs/ls1012ardb_qspi_defconfig | 1 + > configs/ls1012ardb_tfa_SECURE_BOOT_defconfig | 1 + > configs/ls1012ardb_tfa_defconfig | 1 + > configs/ls1043aqds_qspi_defconfig | 1 + > configs/ls1043aqds_sdcard_qspi_defconfig | 1 + > configs/ls1043aqds_tfa_SECURE_BOOT_defconfig | 2 + > configs/ls1043aqds_tfa_defconfig | 1 + > configs/ls1046aqds_qspi_defconfig | 1 + > configs/ls1046aqds_sdcard_qspi_defconfig | 1 + > configs/ls1046aqds_tfa_SECURE_BOOT_defconfig | 1 + > configs/ls1046aqds_tfa_defconfig | 1 + > configs/ls1046ardb_qspi_SECURE_BOOT_defconfig | 1 + > configs/ls1046ardb_qspi_defconfig | 1 + > configs/ls1046ardb_tfa_SECURE_BOOT_defconfig | 1 + > configs/ls1046ardb_tfa_defconfig | 1 + > drivers/spi/fsl_qspi.c | 1574 > ++++++++------------- > drivers/spi/fsl_qspi.h | 145 -- > include/configs/ls1012a_common.h | 17 +- > include/configs/ls1012afrwy.h | 3 - > include/configs/ls1012ardb.h | 3 - > include/configs/ls1021aiot.h | 6 - > include/configs/ls1021aqds.h | 11 - > include/configs/ls1021atwr.h | 10 - > include/configs/ls1043aqds.h | 10 - > include/configs/ls1046afrwy.h | 9 - > include/configs/ls1046aqds.h | 19 - > include/configs/ls1046ardb.h | 20 - > include/configs/ls1088a_common.h | 6 - > include/configs/ls1088aqds.h | 8 - > include/configs/ls1088ardb.h | 18 - > include/configs/ls2080aqds.h | 5 - > include/configs/ls2080ardb.h | 6 +- > include/configs/mx6sxsabreauto.h | 6 - > include/configs/mx6sxsabresd.h | 11 - > include/configs/mx6ul_14x14_evk.h | 6 - > include/configs/mx6ullevk.h | 6 - > include/configs/mx7dsabresd.h | 8 - > include/configs/pcm052.h | 7 - > include/configs/vf610twr.h | 8 - > scripts/config_whitelist.txt | 5 - > 71 files changed, 666 insertions(+), 1382 deletions(-) > delete mode 100644 drivers/spi/fsl_qspi.h
Look fine to me, do you have any comments?
