Hello Tom, thank you for feedback and review. I understand the implications. Would it make sense to document this somewhere to avoid any future confusion?
Thanks, Luka On Thu, Jan 23, 2020 at 1:31 PM Tom Rini <tr...@konsulko.com> wrote: > > On Sun, Jan 05, 2020 at 08:10:56PM +0100, Luka Kovacic wrote: > > > Use the correct return value in function do_gpio() and update > > commands documentation with the return values from command_ret_t enum. > > > > CMD_RET_SUCCESS is returned on command success and CMD_RET_FAILURE is > > returned on command failure. > > > > The command was returning the pin value, which caused confusion when > > debugging (#define DEBUG). > > > > Signed-off-by: Luka Kovacic <luka.kova...@sartura.hr> > > Tested-by: Robert Marko <robert.ma...@sartura.hr> > > So, I think the problem is that despite this not being an optimal user > interface, it's what we've had here for "forever". We can't just go > change it now as there's scripts out in the world (and even > include/configs/) that depend on the current behavior. Sorry, nak. > > -- > Tom
