Hi Corentin, On 22/01/2020 11:04, LABBE Corentin wrote: > On Fri, Jan 17, 2020 at 01:20:44AM +0000, Andre Przywara wrote: >> This series adds Ethernet support for the Raspberry Pi 4. The SoC >> includes a "Broadcom Genet v5 MAC" IP, connected as a proper platform >> device (no USB anymore!). Patch 1 provides a driver for that. There does >> not seem to be publicly available documentation, so this is based on the >> Linux driver, but stripped down to just provide what U-Boot needs. >> Patch 2 fixes up the RPi4 memory map to accommodate the MMIO area the >> MAC lives in, while patch 3 enables it in the respective defconfigs. >> >> This version addresses the comments by the diligent reviewers and testers, >> for a changelog see below. >> To see the individual changes as patches, refer to [1]. >> >> Please have a look and test it, I hope this helps to simplify >> development, as you spare the SD card and its slot from heavy swapping. >> >> I dropped the Tested-by's, as there were changes in the code. Happy >> to reapply them when people confirm that it still works for them. >> >> Cheers, >> Andre. >> >> [1] https://github.com/apritzel/u-boot/commits/rpi4-eth-v2 >> >> Changelog v1 ... v2: >> - use native endianess functions when accessing MMIO registers >> - use dev_* DM wrappers for accessing devicetree data >> - round base and length for flush_dcache_range, plus a comment >> - check and round length for invalidate_cache_range >> - support RGMII_RXID PHY mode, to support mainline .dtb >> >> Amit Singh Tomar (3): >> net: Add support for Broadcom GENETv5 Ethernet controller >> rpi4: Update memory map to accommodate scb devices >> rpi4: Enable GENET Ethernet controller >> >> arch/arm/mach-bcm283x/init.c | 6 +- >> configs/rpi_4_32b_defconfig | 2 + >> configs/rpi_4_defconfig | 2 + >> configs/rpi_arm64_defconfig | 1 + >> drivers/net/Kconfig | 7 + >> drivers/net/Makefile | 1 + >> drivers/net/bcmgenet.c | 722 >> +++++++++++++++++++++++++++++++++++++++++++ >> 7 files changed, 738 insertions(+), 3 deletions(-) >> create mode 100644 drivers/net/bcmgenet.c >> >> -- >> 2.14.5 >> > > Hello > > I have tested it again and grabbing DHCP and doing TFTP works. > But I still fail to boot any kernel. > > U-Boot 2020.01-00660-gec13baddca (Jan 21 2020 - 11:38:05 +0100) > DRAM: 3.9 GiB > RPI 4 Model B (0xc03111) > MMC: emmc2@7e340000: 0, mmcnr@7e300000: 1 > Loading Environment from FAT... *** Warning - bad CRC, using default > environment > In: serial > Out: serial > Err: serial > Net: eth0: genet@7d580000 > > dhcp > > genet@7d580000 Waiting for PHY auto negotiation to complete....... done > BOOTP broadcast 1 > BOOTP broadcast 2 > BOOTP broadcast 3 > DHCP client bound to address 192.168.66.27 (1255 ms) > > I use 0x80000 for kernel, 0x02700000 for RAMfs, 0x02400000 for DTB and booti > 0x00080000 0x02700000 0x02400000 for starting kernel. > Both mainline kernel and rpi kernel wont boot. > > But this is unrelated to your serie.
Thanks for bringing this up. I only tested tftp and was able to run a grub binary. But I realized that with the patches applied, I can't boot a kernel from the SD card neither. As I have grub2 booting the kernel I wonder if you have the same problems? Regards, Matthias > Tested-by: Corentin Labbe <cla...@baylibre.com> > > Thanks > Regards >
