On Sun, Jan 5, 2020 at 7:32 AM Stefano Babic <sba...@denx.de> wrote: > > On 04/01/20 13:03, Joris Offouga wrote: > > Hi Stefano, > > > > Sorry for the delay, > > > > Le 28/12/2019 à 12:31, Stefano Babic a écrit : > >> Hi Joris, > >> > >> > >> > >> On 08/12/19 18:02, Joris Offouga wrote: > >>> Signed-off-by: Joris Offouga <offougajo...@gmail.com> > >>> --- > >>> board/technexion/pico-imx7d/pico-imx7d.c | 46 ------------------------ > >>> configs/pico-dwarf-imx7d_defconfig | 5 +++ > >>> configs/pico-hobbit-imx7d_defconfig | 5 +++ > >>> configs/pico-imx7d_bl33_defconfig | 5 +++ > >>> configs/pico-imx7d_defconfig | 5 +++ > >>> configs/pico-nymph-imx7d_defconfig | 5 +++ > >>> configs/pico-pi-imx7d_defconfig | 5 +++ > >>> include/configs/pico-imx7d.h | 11 ------ > >>> 8 files changed, 30 insertions(+), 57 deletions(-) > >>> > >> I get build errors with pico-imx7d_bl33. > >> > >> https://travis-ci.org/sbabic/u-boot-imx/jobs/630056283 > >> > >> > >> Could you take a look, please ? > > > > I tried to correct the compilation error but I did not find good ways to > > do it, I suggest you remove the usb ethernet support from the > > configuration : > > > > -CONFIG_USB_ETHER=y > > -CONFIG_USB_ETH_CDC=y > > -CONFIG_USBNET_HOST_ADDR="de:ad:be:af:00:00" > > > > If you agree I send V2 > > If the board maintainer (Otavio) agrees it, I am fine.
I agree. However, do this as a commit prior to this one so if someone ever wants to revert it is easy. Also, explain the reasoning on the commit log. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750