On 11.10.19 01:00, Soeren Moch wrote:
> Using a MAC address from ROM storage is the normal case for most
> ethernet hardware. Why should we warn about this?
>
> Signed-off-by: Soeren Moch <sm...@web.de>
Some months ago I came up with the very same patch and I currently have
it in my local fork with the description "Reading the MAC address from
ROM is often a standard use case and should not produce a warning".
Therefore I'm supporting Soeren's and Fabio's point of view here and I'm
in favor of merging this patch or if preferred, change the printf() to
debug().
Reviewed-by: Frieder Schrempf <frieder.schre...@kontron.de>
> ---
> Cc: Joe Hershberger <joe.hershber...@ni.com>
> Cc: u-boot@lists.denx.de
> ---
> net/eth-uclass.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/eth-uclass.c b/net/eth-uclass.c
> index 3bd98b01ad..8b29de37bb 100644
> --- a/net/eth-uclass.c
> +++ b/net/eth-uclass.c
> @@ -538,8 +538,6 @@ static int eth_post_probe(struct udevice *dev)
> memcpy(pdata->enetaddr, env_enetaddr, ARP_HLEN);
> } else if (is_valid_ethaddr(pdata->enetaddr)) {
> eth_env_set_enetaddr_by_index("eth", dev->seq, pdata->enetaddr);
> - printf("\nWarning: %s using MAC address from ROM\n",
> - dev->name);
> } else if (is_zero_ethaddr(pdata->enetaddr) ||
> !is_valid_ethaddr(pdata->enetaddr)) {
> #ifdef CONFIG_NET_RANDOM_ETHADDR
> --
> 2.17.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
>
