Dear Stefan Roese,
In message <1279542253-27041-1-git-send-email...@denx.de> you wrote:
> Using this define, a board can define an opimized RFDC value and use
> the auto calibration code to "tune" the remaining DDR2 controller
> calibration register.
...
> @@ -767,6 +767,13 @@ static u32 DQS_calibration_methodB(struct ddrautocal
> *cal)
>
> debug("\n\n");
>
> +#if defined(CONFIG_DDR_RFDC_FIXED)
> + mtsdram(SDRAM_RFDC, CONFIG_DDR_RFDC_FIXED);
> + size = 512;
> + rffd_average = CONFIG_DDR_RFDC_FIXED & SDRAM_RFDC_RFFD_MASK;
> + mfsdram(SDRAM_RDCC, rdcc); /* record this value */
> + cal->rdcc = rdcc;
> +#else
> in_window = 0;
> rdcc = 0;
>
> @@ -830,6 +837,7 @@ static u32 DQS_calibration_methodB(struct ddrautocal *cal)
> rffd_average = SDRAM_RFDC_RFFD_MAX;
>
> mtsdram(SDRAM_RFDC, rfdc_reg | SDRAM_RFDC_RFFD_ENCODE(rffd_average));
> +#endif
In cases of such long blocks, where the ending #endif is many, many
lines away, it is usually helpful to mark where the #endif belongs to:
#endif /* CONFIG_DDR_RFDC_FIXED */
Please do this here, too.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
I'm a programmer: I don't buy software, I write it.
-- Tom Christiansen
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
