On Thu, Nov 07, 2019 at 08:53:09AM -0700, Simon Glass wrote:
> At present this driver is enabled in SPL on omapl138_lcdk, which uses
> of-platdata. The driver needs to be ported to use of-platdata properly.
> For now, avoid a build error by returning an error.
>
> Signed-off-by: Simon Glass <s...@chromium.org>
>
> ---
>
> Changes in v4:
> - Add new patch for omap MMC build errors
>
> Changes in v3: None
>
> drivers/mmc/davinci_mmc.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/davinci_mmc.c b/drivers/mmc/davinci_mmc.c
> index 0d63279db0..79a7f50d25 100644
> --- a/drivers/mmc/davinci_mmc.c
> +++ b/drivers/mmc/davinci_mmc.c
> @@ -507,6 +507,12 @@ static int davinci_mmc_probe(struct udevice *dev)
> priv->version = data->version;
> }
>
> + /* FIXME: Cannot read from device tree with of-platdata */
> + if (CONFIG_IS_ENABLED(OF_PLATDATA)) {
> + printf("Please fix this driver to use of-platdata");
> + return -ENOSYS;
> + }
> +
> priv->reg_base = (struct davinci_mmc_regs *)dev_read_addr(dev);
> priv->input_clk = clk_get(DAVINCI_MMCSD_CLKID);Let me add the board maintainer here. Peter, are we even using MMC in SPL on the omapl138_lcdk? If so, I believe we need to add platdata ala other platforms like board/ti/am335x/board.c for example. Thanks! -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
