Am 2019-11-05 10:53, schrieb Kuldeep Singh:
Hi Kuldeep,
>> diff --git a/arch/arm/dts/fsl-ls1028a.dtsi
>> b/arch/arm/dts/fsl-ls1028a.dtsi index
>> 43a154e8e7..774e477542 100644
>> --- a/arch/arm/dts/fsl-ls1028a.dtsi
>> +++ b/arch/arm/dts/fsl-ls1028a.dtsi
>> @@ -49,14 +49,16 @@
>> <1 10 0x8>; /* Hypervisor PPI,
>> active-low */
>> };
>>
>> - fspi: flexspi@20C0000 {
>> - compatible = "nxp,dn-fspi";
>> + fspi: flexspi@20c0000 {
>> + compatible = "nxp,lx2160a-fspi";
>> #address-cells = <1>;
>> #size-cells = <0>;
>> - reg = <0x0 0x20C0000 0x0 0x10000>,
>> - <0x0 0x20000000 0x0 0x10000000>; /*64MB
>> flash*/
>> - reg-names = "FSPI", "FSPI-memory";
>> - num-cs = <1>;
>> + reg = <0x0 0x20c0000 0x0 0x10000>,
>> + <0x0 0x20000000 0x0 0x10000000>;
>> + reg-names = "fspi_base", "fspi_mmap";
>> + clocks = <&clockgen 4 3>, <&clockgen 4 3>;
>> + clock-names = "fspi_en", "fspi";
>> + interrupts = <0 25 0x4>;
>
> Please change the interrupts to "<GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>" as
> it avoids magic numbers.
This is consistent with the other interrupt properties, which doesn't
have these
constants either. IMHO another commit where all these magic numbers
are
removed would be better.
I just checked and found no interrupt handler in spi/nxp_fspi.c
driver. So, it's better to remove this line altogether. What do you
think?
For the sake of consistency (with all other nodes and with the linux
device tree) and if someone would like to sync the device tree with the
linux one, I'd keep that. Like I said before, I'd do another patch were
all interrupt magic numbers are replaced with the correct constants.
-michael
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
