Hi Bin, On Tue, 29 Oct 2019 at 07:56, Bin Meng <[email protected]> wrote: > > Hi Simon, > > On Tue, Oct 29, 2019 at 11:37 AM Simon Glass <[email protected]> wrote: > > > > Hi Bin, > > > > On Mon, 28 Oct 2019 at 08:25, Bin Meng <[email protected]> wrote: > > > > > > In the 'Make' function, the codes tries to create a directory > > > if current stage is 'build'. But the directory isn't used at > > > all anywhere. > > > > > > Signed-off-by: Bin Meng <[email protected]> > > > > > > --- > > > > > > Changes in v2: > > > - remove the unneeded debug codes > > > > > > tools/buildman/test.py | 8 -------- > > > 1 file changed, 8 deletions(-) > > > > Can you check this works OK when there is no output dir at all? E.g. > > > > -o /path/to/a/deep/non-existent/dir > > If I understand the codes correctly the "O=<path>" in args[] does not > come from "-o /path/to/a/deep/non-existent/dir" but from the > builderthread with some hardcoded values. The removed codes here seem > to do something not very useful.
That's fine, and TBH if we hit a problem later due to this we should add a unit test to cover it. Regards, Simon _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
