Hi > > > > Adding general register structure of system control module (SCM) > > > > of AM35x. This would be required to access devconf2 and ip_sw_reset > > > > register in musb module. > > > > > > > > Signed-off-by: Ajay Kumar Gupta <[email protected]> > > > > --- > > > > arch/arm/include/asm/arch-omap3/cpu.h | 20 ++++++++++++++++++++ > > > > 1 files changed, 20 insertions(+), 0 deletions(-) > > > > > > > > diff --git a/arch/arm/include/asm/arch-omap3/cpu.h > > > > b/arch/arm/include/asm/arch-omap3/cpu.h > > > > index c072c27..773ea0c 100644 > > > > --- a/arch/arm/include/asm/arch-omap3/cpu.h > > > > +++ b/arch/arm/include/asm/arch-omap3/cpu.h > > > > @@ -483,4 +483,24 @@ struct pm { > > > > #define I2C_BASE2 (OMAP34XX_CORE_L4_IO_BASE + 0x72000) > > > > #define I2C_BASE3 (OMAP34XX_CORE_L4_IO_BASE + 0x60000) > > > > > > > > +/* AM35x specific */ > > > > +#ifndef __KERNEL_STRICT_NAMES > > > > +#ifndef __ASSEMBLY__ > > > > +#define AM35X_SCM_GEN_BASE 0x48002270 > > > > +/* General register mappings of system control module */ > > > > +struct am35x_scm_general { > > > > + u32 res1[0xC4]; /* 0x000 - 0x30C */ > > > > + u32 devconf2; /* 0x310 */ > > > > + u32 devconf3; /* 0x314 */ > > > > + u32 res2[0x2]; /* 0x318 - 0x31C */ > > > > + u32 cba_priority; /* 0x320 */ > > > > + u32 lvl_intr_clr; /* 0x324 */ > > > > + u32 ip_sw_reset; /* 0x328 */ > > > > + u32 ipss_clk_ctrl; /* 0x32C */ > > > > +}; > > > > > > Shouldn't this structure be in a am35 specific header? > > > > AM35x is based on OMAP3x and moreover there is no AM35x specific > understood > > File so I added them here. Do you want me to add a header for > > AM35x as arch/arm/include/asm/arch-omap3/am35x.h ? > > > > Thanks, > > Ajay > > > > -- > > What about > drivers/usb/musb/am35x.h > which you just created in your patch set
am35x_scm_general is a system register sets and can be used by non usb modules as well so I think drivers/usb/musb/am35x.h would not be a right place. Are you concerned of same name file instead? If so then we can have Different names for these files. Thanks, Ajay > > > Thanks, > Sandeep _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
