On Wed, Jul 10, 2019 at 01:46:57PM +0200, Nuno Gonçalves wrote: > Hi, > > I found out that my Beaglebone didn't boot after: > > https://github.com/u-boot/u-boot/commit/13dd6665ed18f72380ca596931d609bc108d4b82 > > I digged out the reason that this patch makes devnum a local variable, > and it ends up shadowed by other code that sets devnum as a env > variable. > > For example to boot on the beaglebone I had to remove the setenv as in > the patch below. > > This only fixes for my board. Many other will likely have regressions. > > Fixing it for all boards in a reliable way I think is very complex, > unless the strategy is to wait for board maintainers to fix it as they > need it, but I wonder how many latent bugs this will create for corner > boot cases. > > Maybe this change is not worth it? > > Thanks, > Nuno
I've checked other usages here and only the TI case looks to have been a problem. I reworded the commit message as well. Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
