Stephan Linz wrote: > Am Dienstag, 22. Juni 2010 09:24:40 schrieb Michal Simek: >> Stephan Linz wrote: >>> Foresighted to support flat device tree realocations we need to use >>> the new Logical memory blocks library in a manner as been used by all >>> other architectures. >>> >>> Signed-off-by: Stephan Linz <l...@li-pro.net> >>> --- >>> arch/microblaze/include/asm/config.h | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/microblaze/include/asm/config.h >>> b/arch/microblaze/include/asm/config.h index 8a9064b..ec2c316 100644 >>> --- a/arch/microblaze/include/asm/config.h >>> +++ b/arch/microblaze/include/asm/config.h >>> @@ -21,6 +21,8 @@ >>> #ifndef _ASM_CONFIG_H_ >>> #define _ASM_CONFIG_H_ >>> >>> +#define CONFIG_LMB >>> + >> I see what you are trying to do but what >> is your point with enabling LMB support ? > > Hm, mainly a clean compilation. Without this define I can not enable the flat > device tree handling. LMB is quite new in U-Boot (PowerPC) and there are some > dependencies to the FDT support. That force to enable even this feature on > MicroBlaze too. I want to avoid a deep intrusion into the code.
I am not using the latest u-boot code - just checking if compilation is OK. But I can't see a reason why we should enable LMB because we don't need it. If there is any dependency then there are missing some ifdefs. > >> I am not sure if this enabling bring us any feature which we need. > > Hm, could you pleace consult the PowerPC folks? I think LMB is used to > transfer system memory map from U-Boot to Linux kernel in a common way > (similar like on x86 PC from BIOS to kernel), or not? Any comments? Stefan: How is LMB used in PowerPC? Microblaze uses LMB in kernel but IMHO we don't need to use it in u-boot and kernel is not ready for passing any memory map from U-BOOT. Maybe I am wrong that's why I would like to check this with you. Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
