Hi Frieder > -----Original Message----- > From: Schrempf Frieder <frieder.schre...@kontron.de> > Sent: 2019年8月14日 15:22 > To: Peng Fan <peng....@nxp.com>; lu...@denx.de; sba...@denx.de; > feste...@gmail.com > Cc: dl-uboot-imx <uboot-...@nxp.com>; u-boot@lists.denx.de > Subject: Re: [PATCH 01/22] tools: imx8m_image: align spl bin image size > > Hi Peng, > > On 09.08.19 06:14, Peng Fan wrote: > > Align spl bin image size to 4 byte aligned, because we need to pad ddr > > firmware in the end of spl bin. However when enable SPL OF, the spl > > dtb will be padded to u-boot-nodtb.bin, then u-boot-spl.bin size might > > not be 4 bytes aligned. > > > > ddr_load_train_firmware in drivers/ddr/imx/imx8m/helper.c use 4 bytes > > aligned address to load ddr firmware, so we need make sure > > u-boot-spl.bin is 4 bytes aligned, in this patch we use dd to create a > > new file named u-boot-spl-pad.bin, then pad ddr firmware. > If SPL OF > > not enabled, this patch not hurt, because `_end` already is 4 bytes > > aligned. > > Can you please try to make full English sentences at least? Like "subject verb > object": If SPL *is* not enabled, this patch *does* not hurt, ... >
I'll try. > Also your explanations are very difficult to understand for someone who will > read the commit message. Sorry. My English is not that good. I would have used something like this: > > """ > The loader for the DDR firmware in drivers/ddr/imx/imx8m/helper.c uses a > 4-byte-aligned address to load the firmware. In cases where OF is enabled in > SPL the dtb will be appended to the SPL binary and can result in a binary that > is not aligned correctly. If OF is not enabled in SPL, `_end` is already > aligned > correctly, but this patch does not hurt. > > To ensure the correct alignment we use dd to create a temporary file > u-boot-spl-pad.bin with the correct padding. > """ Thanks for help improve the commit message. Thanks, Peng. > > > > > Signed-off-by: Peng Fan <peng....@nxp.com> > > With a better commit message: > > Reviewed-by: Frieder Schrempf <frieder.schre...@kontron.de> > Tested-by: Frieder Schrempf <frieder.schre...@kontron.de> > > Thanks, > Frieder > > > --- > > tools/imx8m_image.sh | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/tools/imx8m_image.sh b/tools/imx8m_image.sh index > > ec0881a128..08a6a48180 100755 > > --- a/tools/imx8m_image.sh > > +++ b/tools/imx8m_image.sh > > @@ -35,8 +35,9 @@ if [ $post_process = 1 ]; then > > objcopy -I binary -O binary --pad-to 0x8000 --gap-fill=0x0 > $srctree/lpddr4_pmu_train_2d_imem.bin > lpddr4_pmu_train_2d_imem_pad.bin > > cat lpddr4_pmu_train_1d_imem_pad.bin > lpddr4_pmu_train_1d_dmem_pad.bin > lpddr4_pmu_train_1d_fw.bin > > cat lpddr4_pmu_train_2d_imem_pad.bin > $srctree/lpddr4_pmu_train_2d_dmem.bin > lpddr4_pmu_train_2d_fw.bin > > - cat spl/u-boot-spl.bin lpddr4_pmu_train_1d_fw.bin > lpddr4_pmu_train_2d_fw.bin > spl/u-boot-spl-ddr.bin > > - rm -f lpddr4_pmu_train_1d_fw.bin lpddr4_pmu_train_2d_fw.bin > lpddr4_pmu_train_1d_imem_pad.bin lpddr4_pmu_train_1d_dmem_pad.bin > lpddr4_pmu_train_2d_imem_pad.bin > > + dd if=spl/u-boot-spl.bin of=spl/u-boot-spl-pad.bin bs=4 > > conv=sync > > + cat spl/u-boot-spl-pad.bin lpddr4_pmu_train_1d_fw.bin > lpddr4_pmu_train_2d_fw.bin > spl/u-boot-spl-ddr.bin > > + rm -f lpddr4_pmu_train_1d_fw.bin lpddr4_pmu_train_2d_fw.bin > > +lpddr4_pmu_train_1d_imem_pad.bin > lpddr4_pmu_train_1d_dmem_pad.bin > > +lpddr4_pmu_train_2d_imem_pad.bin spl/u-boot-spl-pad.bin > > fi > > fi > > > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
