Hi Marek, On Thu, Aug 8, 2019 at 1:02 AM Marek Behún <marek.be...@nic.cz> wrote: > > The non-DM version of this driver used to set BAR0 register after the > calls to pci_set_region. > I found out that for some strange reason the ath10k driver in kernel > fails to work if this is done the other way around. > I know that Linux's driver should not depend on how U-Boot does things, > but for some strange reason it does and this seems to be the simplest > solution. Fix it since it caused regressions on Omnia. > > Signed-off-by: Marek Behún <marek.be...@nic.cz> > Cc: Stefan Roese <s...@denx.de> > Cc: Dirk Eibach <dirk.eib...@gdsys.cc> > Cc: Mario Six <mario....@gdsys.cc> > Cc: Chris Packham <chris.pack...@alliedtelesis.co.nz> > Cc: Phil Sutter <p...@nwl.cc> > Cc: VlaoMao <vlao...@gmail.com>
Tested-by: Chris Packham <judge.pack...@gmail.com> > --- > drivers/pci/pci_mvebu.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c > index e21dc10c2f..f9b08f38a1 100644 > --- a/drivers/pci/pci_mvebu.c > +++ b/drivers/pci/pci_mvebu.c > @@ -313,10 +313,6 @@ static int mvebu_pcie_probe(struct udevice *dev) > reg |= BIT(10); /* disable interrupts */ > writel(reg, pcie->base + PCIE_CMD_OFF); > > - /* Set BAR0 to internal registers */ > - writel(SOC_REGS_PHY_BASE, pcie->base + PCIE_BAR_LO_OFF(0)); > - writel(0, pcie->base + PCIE_BAR_HI_OFF(0)); > - > /* PCI memory space */ > pci_set_region(hose->regions + 0, pcie->mem.start, > pcie->mem.start, PCIE_MEM_SIZE, PCI_REGION_MEM); > @@ -326,6 +322,10 @@ static int mvebu_pcie_probe(struct udevice *dev) > PCI_REGION_MEM | PCI_REGION_SYS_MEMORY); > hose->region_count = 2; > > + /* Set BAR0 to internal registers */ > + writel(SOC_REGS_PHY_BASE, pcie->base + PCIE_BAR_LO_OFF(0)); > + writel(0, pcie->base + PCIE_BAR_HI_OFF(0)); > + > bus++; > > return 0; > -- > 2.21.0 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
