On Saturday, June 19, 2010 20:20:33 y...@denx.de wrote:
> Commit 37566090 "compiler.h: unify system ifdef cruft here" added both
> a "#include <errno.h>" and a "extern int errno;" to include/compiler.h

it isnt new code, it sucked the definitions out of random files that had these 
and into one place

> which is causing build warnings for some systems, for example for the
> "netstar" board:
> 
>       In file included from /home/wd/git/u-boot/work/lib/crc32.c:15:
>       include/compiler.h:28: warning: function declaration isn't a prototype

never seen that, but i imagine re-ordering the lines might address it as well 
(extern then include)

> The declaration of "errno" should be redundant, as <errno.h> is
> supposed to provide a correct declaration, so drop it.

there are older systems where this isnt true, but ive never used one myself 
and if we dont care about them (i dont), then this is fine
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to