On Fri, Jul 12, 2019 at 6:47 PM Simon Goldschmidt <simon.k.r.goldschm...@gmail.com> wrote: > > On Thu, Jul 11, 2019 at 1:03 AM Ley Foon Tan <lftan.li...@gmail.com> wrote: > > > > On Tue, Jul 9, 2019 at 1:13 PM Simon Goldschmidt > > <simon.k.r.goldschm...@gmail.com> wrote: > > > > > > Am 04.07.2019 um 10:56 schrieb Ley Foon Tan: > > > > Add clock manager driver for Agilex. Provides clock initialization > > > > and get_rate functions. > > > > > > Thanks for adding this to the patchset. This is quite a big change, I > > > don't have the time currently to review it. Just a question to the > > > message above: does 'clock' initialization mean it reads the > > > initialization values from devicetree instead of reading them from qts > > > header files? If so, is the code better integrated then the A10 code? > > For S10 and Agilex, the initialization values is from handoff in FPGA > > image, not from device tree as A10. > > It is much simpler than A10 implementation. > > > > > > And further asked, if this works for Agilex, and you added > > > "stratix10-clock.h", does this work for S10, too? > > Actually "stratix10-clock.h" is from Linux tree, > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/dt-bindings/clock/stratix10-clock.h > > I can add Linux commit ID in commit message. > > You already did that. My question was: does this clock driver work for > Stratix10, too, given the name of the file you imported? > Clock manager for Stratix10 and Agilex are different. But, include/dt-bindings/clock/stratix10-clock.h can use for both Stratix10 and Agilex. stratix10-clock.h contains SW define index for each clock, so it is not depend on HW.
Regards Ley Foon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
