On Mon, Jul 22, 2019 at 11:14 PM Andy Shevchenko <andy.shevche...@gmail.com> wrote: > > On Wed, Jul 17, 2019 at 7:41 AM Park, Aiden <aiden.p...@intel.com> wrote: > > > > This slimbootloader cpu type is to enable U-Boot as a payload which > > cpu -> CPU > > > runs on top of Slim Bootloader(https://github.com/slimbootloader). > > The Slim Bootloader is designed with multi-stage architecture for > > the execution from reset vector to OS booting, and supports qemu, > > qemu -> QEMU > > > Apollolake, Whiskeylake and Coffeelake platforms consuming Intel FSP > > (https://github.com/IntelFsp) for silicon initialization including > > CAR and memory initialization. > > The Slim Bootloader generates new HOB(Hand Off Block) which are > > serial port info, memory map info, performance data info and so on, > > and passes it to a Payload. U-Boot as a payload will use these HOB > > information for basic initialization such as serial console. > > > +config SYS_SLIMBOOTLOADER > > > + bool > > + default y > > def_bool y ?
Good catch. I checked other x86 Kconfig files, and seems we should just remove this line, and specify SYS_SLIMBOOTLOADER in the board defconfig file. > > > + imply SYS_NS16550 > > + imply AHCI_PCI > > + imply SCSI > > + imply SCSI_AHCI > > + imply MMC > > + imply MMC_PCI > > + imply MMC_SDHCI > > + imply MMC_SDHCI_SDMA > > + imply USB > > + imply USB_EHCI_HCD > > + imply USB_XHCI_HCD > > + imply USB_STORAGE > > + imply USB_KEYBOARD > > + imply E1000 > > > + imply RTL8169 > > Is it part of SoC? I dunno we have Realtek inside, usually either > Intel or Synopsys. > I think the following should be moved to board/intel/slimbootloader/Kconfig::BOARD_SPECIFIC_OPTIONS: imply USB_STORAGE imply USB_KEYBOARD imply RTL8169 > > -#ifndef CONFIG_HAVE_FSP > > +#if !defined(CONFIG_HAVE_FSP) && !defined(CONFIG_SYS_SLIMBOOTLOADER) > > > -#ifdef CONFIG_HAVE_FSP > > +#if defined(CONFIG_HAVE_FSP) || defined(CONFIG_SYS_SLIMBOOTLOADER) > Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
