On 6/23/19 8:31 AM, Heinrich Schuchardt wrote:
> When a crash occurs in thumbs
It's Thumb , not Thumbs.
You should take CONFIG_ARM_THUMB off the config whitelist too.
> mode the crash dump is incorrect. This is due
> to the usage of a non-existing configuration variable CONFIG_ARM_THUMB in
> the definition of macro thumb_mode(regs).
>
> Use CONFIG_IS_ENABLED(SYS_THUMB_BUILD) to detect that the code has been
> compiled for thumbs mode.
>
> With the patch crash dumps indicate thumbs mode correctly.
>
> On a system with thumbs mode:
>
> => exception unaligned
> data abort
> pc : [<8f7a2b52>] lr : [<8f7ab1ef>]
> reloc pc : [<1780cb52>] lr : [<178151ef>]
> sp : 8ed8c3f8 ip : 8f7a2b4d fp : 00000002
> r10: 8f7f8228 r9 : 8ed95ea8 r8 : 8ed99488
> r7 : 8f7ab141 r6 : 00000000 r5 : 8ed8c3f9 r4 : 8f7f6390
> r3 : 8ed9948c r2 : 00000001 r1 : 00000000 r0 : 8f7f6390
> Flags: nzCv IRQs off FIQs off Mode SVC_32 (T)
> Code: 8f7e 466d f105 0501 (e9d5) 6700
>
> The Flags line has '(T)' and in the Code line the output is in u16 groups.
>
> On a system without thumbs mode:
>
> => exception breakpoint
> prefetch abort
> pc : [<7ff5a5c8>] lr : [<7ff675ec>]
> reloc pc : [<0000e5c8>] lr : [<0001b5ec>]
> sp : 7ee0ad80 ip : 7ff5a5cc fp : 7ff674cc
> r10: 00000002 r9 : 7ef0bed8 r8 : 7ffd6214
> r7 : 7ef0e080 r6 : 00000000 r5 : 7ffd4090 r4 : 00000000
> r3 : 7ef0e084 r2 : 00000001 r1 : 00000000 r0 : 7ffd4090
> Flags: nzCv IRQs off FIQs off Mode SVC_32
> Code: e1a0500d e2855001 e1c560d0 e3a00001 (e12fff1e)
>
> The Flags line does not show '(T)' and in the Code line the output is in
> u32 groups.
>
> Reported-by: Marek Vasut <ma...@denx.de>
> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>
> ---
> arch/arm/include/asm/proc-armv/ptrace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/proc-armv/ptrace.h
> b/arch/arm/include/asm/proc-armv/ptrace.h
> index 183b00a087..e37ad8fd1f 100644
> --- a/arch/arm/include/asm/proc-armv/ptrace.h
> +++ b/arch/arm/include/asm/proc-armv/ptrace.h
> @@ -86,7 +86,7 @@ struct pt_regs {
> #define user_mode(regs) \
> (((regs)->ARM_cpsr & 0xf) == 0)
>
> -#ifdef CONFIG_ARM_THUMB
> +#if CONFIG_IS_ENABLED(SYS_THUMB_BUILD)
> #define thumb_mode(regs) \
> (((regs)->ARM_cpsr & T_BIT))
> #else
> --
> 2.20.1
>
--
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
