Hi Bin, > -----Original Message----- > From: Z.q. Hou > Sent: Friday, May 24, 2019 7:42 PM > To: Bin Meng <bmeng...@gmail.com> > Cc: Xiaowei Bao <xiaowei....@nxp.com>; Simon Glass <s...@chromium.org>; > u-boot@lists.denx.de; Prabhakar Kushwaha <prabhakar.kushw...@nxp.com>; > w...@denx.de; Shengzhou Liu <shengzhou....@nxp.com>; Jagdish Gediya > <jagdish.ged...@nxp.com>; ley.foon....@intel.com; s...@denx.de; M.h. Lian > <minghuan.l...@nxp.com> > Subject: RE: [EXT] Re: [PATCHv2 8/8] configs: T2080QDS: Enable PCIe driver > > Hi Bin, > > > -----Original Message----- > > From: Bin Meng [mailto:bmeng...@gmail.com] > > Sent: 2019年5月24日 17:38 > > To: Z.q. Hou <zhiqiang....@nxp.com> > > Cc: Xiaowei Bao <xiaowei....@nxp.com>; Simon Glass <s...@chromium.org>; > > u-boot@lists.denx.de; Prabhakar Kushwaha > <prabhakar.kushw...@nxp.com>; > > w...@denx.de; Shengzhou Liu <shengzhou....@nxp.com>; Jagdish Gediya > > <jagdish.ged...@nxp.com>; ley.foon....@intel.com; s...@denx.de; M.h. > > Lian <minghuan.l...@nxp.com> > > Subject: Re: [EXT] Re: [PATCHv2 8/8] configs: T2080QDS: Enable PCIe > > driver > > > > Hi Zhiqiang, > > > > On Fri, May 24, 2019 at 4:17 PM Z.q. Hou <zhiqiang....@nxp.com> wrote: > > > > > > Hi Bin and Prabhakar, > > > > > > Thanks a lot for your comments! > > > > > > > -----Original Message----- > > > > From: Bin Meng [mailto:bmeng...@gmail.com] > > > > Sent: 2019年5月24日 10:14 > > > > To: Xiaowei Bao <xiaowei....@nxp.com>; Simon Glass > > > > <s...@chromium.org> > > > > Cc: Z.q. Hou <zhiqiang....@nxp.com>; u-boot@lists.denx.de; > > > > Prabhakar Kushwaha <prabhakar.kushw...@nxp.com>; w...@denx.de; > > > > Shengzhou > > Liu > > > > <shengzhou....@nxp.com>; Jagdish Gediya <jagdish.ged...@nxp.com>; > > > > ley.foon....@intel.com; s...@denx.de; M.h. Lian > > > > <minghuan.l...@nxp.com> > > > > Subject: Re: [EXT] Re: [PATCHv2 8/8] configs: T2080QDS: Enable > > > > PCIe driver > > > > > > > > On Fri, May 24, 2019 at 10:10 AM Xiaowei Bao <xiaowei....@nxp.com> > > > > wrote: > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Bin Meng <bmeng...@gmail.com> > > > > > Sent: 2019年5月24日 8:11 > > > > > To: Z.q. Hou <zhiqiang....@nxp.com> > > > > > Cc: u-boot@lists.denx.de; Prabhakar Kushwaha > > > > > <prabhakar.kushw...@nxp.com>; w...@denx.de; Shengzhou Liu > > > > > <shengzhou....@nxp.com>; Jagdish Gediya > > > > > <jagdish.ged...@nxp.com>; s...@chromium.org; > > > > > ley.foon....@intel.com; s...@denx.de; M.h. Lian > > > > > <minghuan.l...@nxp.com>; Xiaowei Bao <xiaowei....@nxp.com> > > > > > Subject: [EXT] Re: [PATCHv2 8/8] configs: T2080QDS: Enable PCIe > > > > > driver > > > > > > > > > > Caution: EXT Email > > > > > > > > > > Hi, > > > > > > > > > > On Fri, May 24, 2019 at 12:04 AM Z.q. Hou <zhiqiang....@nxp.com> > > wrote: > > > > > > > > > > > > Hi Bin, > > > > > > > > > > > > Thanks a lot for your comments! > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Bin Meng [mailto:bmeng...@gmail.com] > > > > > > > Sent: 2019年5月23日 22:23 > > > > > > > To: Z.q. Hou <zhiqiang....@nxp.com> > > > > > > > Cc: u-boot@lists.denx.de; Prabhakar Kushwaha > > > > > > > <prabhakar.kushw...@nxp.com>; w...@denx.de; Shengzhou Liu > > > > > > > <shengzhou....@nxp.com>; Jagdish Gediya > > > > > > > <jagdish.ged...@nxp.com>; s...@chromium.org; > > > > > > > ley.foon....@intel.com; s...@denx.de; M.h. Lian > > > > > > > <minghuan.l...@nxp.com>; Xiaowei Bao <xiaowei....@nxp.com> > > > > > > > Subject: Re: [PATCHv2 8/8] configs: T2080QDS: Enable PCIe > > > > > > > driver > > > > > > > > > > > > > > On Thu, May 23, 2019 at 8:22 PM Z.q. Hou > > > > > > > <zhiqiang....@nxp.com> > > > > wrote: > > > > > > > > > > > > > > > > From: Hou Zhiqiang <zhiqiang....@nxp.com> > > > > > > > > > > > > > > > > Enable the DM PCIe driver in T2080QDS defconfig. > > > > > > > > > > > > > > > > Signed-off-by: Hou Zhiqiang <zhiqiang....@nxp.com> > > > > > > > > --- > > > > > > > > V2: > > > > > > > > - Enable PCIe in NAND flash, SD card and SPI flash boot > > > > > > > > defconfig. > > > > > > > > > > > > > > > > configs/T2080QDS_NAND_defconfig | 4 ++++ > > > > > > > > configs/T2080QDS_SDCARD_defconfig | 4 ++++ > > > > > > > > configs/T2080QDS_SPIFLASH_defconfig | 4 ++++ > > > > > > > > configs/T2080QDS_defconfig | 4 ++++ > > > > > > > > 4 files changed, 16 insertions(+) > > > > > > > > > > > > > > > > diff --git a/configs/T2080QDS_NAND_defconfig > > > > > > > > b/configs/T2080QDS_NAND_defconfig index > > > > > > > > 948a05af89..d04e223c23 > > > > > > > 100644 > > > > > > > > --- a/configs/T2080QDS_NAND_defconfig > > > > > > > > +++ b/configs/T2080QDS_NAND_defconfig > > > > > > > > @@ -38,6 +38,7 @@ > > > > > > > > > > > > > > > > > > > > > CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kern > > > > > > > el),1 > > > > > > > > 28k(dtb),9 > > > > > > > > CONFIG_OF_CONTROL=y > > > > > > > > CONFIG_DEFAULT_DEVICE_TREE="t2080qds" > > > > > > > > CONFIG_ENV_IS_IN_NAND=y > > > > > > > > +CONFIG_DM=y > > > > > > > > CONFIG_FSL_CAAM=y > > > > > > > > CONFIG_FSL_ESDHC=y > > > > > > > > CONFIG_MTD_NOR_FLASH=y > > > > > > > > @@ -54,6 +55,9 @@ CONFIG_PHYLIB=y > > > > CONFIG_PHY_AQUANTIA=y > > > > > > > > CONFIG_E1000=y CONFIG_MII=y > > > > > > > > +CONFIG_DM_PCI=y > > > > > > > > +CONFIG_DM_PCI_COMPAT=y > > > > > > > > > > > > > > I think we should avoid adding DM_PCI_COMPAT. > > > > > > > > > > > > Without this macro the non-DM Endpoint driver (such as e1000) > > > > > > won't > > > > work. > > > > > > > > > > e1000 is a fully DM driver now. Please redo the testing. > > > > > [Xiaowei Bao] I am not very clear, If someone want to implement > > > > > the > > > > customized device driver(not DM) in u-boot, the driver will not work, > > > > yes? > > > > > > > > We are going to convert all drivers to DM in U-Boot. There are > > > > some deadlines to be set already. So you don't need consider such > > > > non-dm compatibility. > > > > > > To enable e1000 DM driver, I added the DM_ETH to T2080QDS_defconfig, > > > but some build errors arose, seems FMan driver is not DM compatible. > > > The DM e1000 driver works well with DPAA FMan driver disabled. > > > > > > > This is expected. E1000 requires DM_ETH, that means all ethernet > > drivers in your system have to be DM. So do you have plan to convert > > the FMAN ethernet driver to DM? > > No, I don't, perhaps my colleague is working on this, I will submit a patch to > remove the DM_PCI_COMPAT when all driver has been converted. > >
Considering there is no immediate plan to move FMAN ethernet to DM model. There is no point of holding this patch series. I am planning to accept this patch series. Please do let us know, if you have any further review comments/concern.. --pk _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
