Hi Bin > > Hi Rick, > > On Tue, May 28, 2019 at 5:44 PM Andes <ub...@andestech.com> wrote: > > > > From: Rick Chen <r...@andestech.com> > > > > Flush and disable cache in cleanup_before_linux() > > which will be called before jump to linux. > > > > The sequence will be preferred as below: > > L1 flush -> L1 disable -> L2 flush -> L2 disable > > > > Signed-off-by: Rick Chen <r...@andestech.com> > > Cc: Greentime Hu <greent...@andestech.com> > > --- > > arch/riscv/cpu/ax25/cpu.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/riscv/cpu/ax25/cpu.c b/arch/riscv/cpu/ax25/cpu.c > > index 76689b2..9e7579a 100644 > > --- a/arch/riscv/cpu/ax25/cpu.c > > +++ b/arch/riscv/cpu/ax25/cpu.c > > @@ -7,6 +7,7 @@ > > /* CPU specific code */ > > #include <common.h> > > #include <asm/cache.h> > > +#include <asm/v5l2cache.h> > > > > /* > > * cleanup_before_linux() is called just before we call linux > > @@ -22,6 +23,9 @@ int cleanup_before_linux(void) > > cache_flush(); > > icache_disable(); > > dcache_disable(); > > +#ifdef CONFIG_RISCV_NDS_CACHE > > + v5l2_disable(); > > +#endif > > The direct call into a driver should be avoided. Instead, use a proper > DM cache uclass driver API (see my review comments in patch [1/6])
OK I will use DM cache uclass driver API to disable L2 driver. Thanks Rick > > Regards, > Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
