Hi, On 14/05/19 17:45, Michal Simek wrote: >>>>>>> +$(obj)/pm_cfg_obj.o: $(obj)/pm_cfg_obj.bin >>>>>>> + >>>>>>> +CFLAGS_zynqmp.o += -DZYNQMP_LOAD_PM_CFG_OBJ >>>>>> >>>>>> I am no fan of passing another object. you have >>>>>> CONFIG_ZYNQMP_LOAD_PM_CFG_OBJ_FILE already and this can be used instead. >>>>> >>>>> Not sure I got your point here. I'm not passing an object, just setting >>>>> a define (without value). This is used to enable code under #ifdef in C >>>>> files. >>>> >>>> Sorry I meant new config option. It should be enough to use CFG_OBJ_FILE >>>> everywhere and not create another config option which is just used the >>>> same way. >>> >>> I totally agree. But I would need to check whether >>> CONFIG_ZYNQMP_LOAD_PM_CFG_OBJ_FILE is empty or not, and I don't think >>> the C preprocessor can do that. >> >> Any news on this issue? It's the only issue still open on this series, >> and as said, I don't think there's a way to avoid the extra define. As >> such, unless a smart solution emerges suddenly, I'm sending v4 in one or >> two days with all the other issues fixed. > > I didn't spend any time on this. Try to grep it. If you don't file > anything please add there TODO and let's fix it in future.
I did grep and searched, but the core problem is that the preprocessor cannot compare strings. But now I found a way out. Looks a bit of a hack to me, but it works, will be in v4. If that's not OK, I'll do v5 with the current solution and a TODO. -- Luca _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
