On Tue, May 14, 2019 at 4:35 PM Simon Goldschmidt <simon.k.r.goldschm...@gmail.com> wrote: > > On Tue, May 14, 2019 at 8:08 AM Ley Foon Tan <lftan.li...@gmail.com> wrote: > > > > On Sat, May 11, 2019 at 2:28 AM Simon Goldschmidt > > <simon.k.r.goldschm...@gmail.com> wrote: > > > > > > Am 10.05.2019 um 07:54 schrieb Ley Foon Tan: > > > > Add reset manager support for Agilex. > > > > > > > > Signed-off-by: Ley Foon Tan <ley.foon....@intel.com> > > > > --- > > > > .../mach-socfpga/include/mach/reset_manager.h | 5 ++- > > > > .../include/mach/reset_manager_agilex.h | 38 +++++++++++++++++++ > > > > arch/arm/mach-socfpga/reset_manager.c | 9 +++-- > > > > > > Have you seen my series that removes reset_manager.c and moves the code > > > to drivers/sysreset instead? It's not accepted, yet, but I think agilex > > > should use drivers/sysreset, too. > > > > > > Regards, > > > Simon > > drivers/sysreset is only for system reset, right? > > Most of our drivers use reset framework to reset, but we still using > > functions from reset_manager to reset watchdog and UART (when > > CONFIG_DEBUG_UART enabeld). > > Right, but arch/arm/mach-socfpga/reset_manager.c only contains > reset_cpu(), so drivers/sysreset is a direct replacement for this. > > You're probably talking about reset_manager_s10.c. I know you still > need that (although I'm trying to find a way to move that code to > dm driver, too - at least for gen5 as a start). > Yes, I am talking about reset_manager_s10.c.
Regards Ley Foon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
