> Subject: Re: [PATCH 2/2] riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables
> extlinux)
>
> On Fri, Apr 12, 2019 at 12:38 AM Auer, Lukas <lukas.a...@aisec.fraunhofer.de>
> wrote:
> >
> > On Thu, 2019-04-11 at 14:51 +0200, David Abdurachmanov wrote:
> > > On Thu, Apr 11, 2019 at 2:41 PM Auer, Lukas
> > > <lukas.a...@aisec.fraunhofer.de> wrote:
> > > > + Bin
> > > >
> > > > On Tue, 2019-04-09 at 12:42 +0200, David Abdurachmanov wrote:
> > > > - Set fdt_addr variable, which is needed for extlinux to find FDT.
> > > > Otherwise booting kernel using extlinux results in missing FDT.
> > > >
> > > > - Also run fdt addr with FDT address so that fdt commands would
> > > > work out of the box in U-Boot prompt.
> > >
> > > > While often useful to have, the fdt command is not used during a
> > > > normal boot. I think we should avoid calling commands, which are
> > > > not normally needed. Can you remove this from your patch?
> > >
> > > I borrowed idea from other boards, and I find it useful to have fdt
> > > working out-of-the-box without trying to figure the correct variable
> > > which holds address of FDT.
> > >
> > > I can remove it from the patch, but I will probably keep adding it
> > > as Fedora specific patch then.
> > >
> >
> > That makes sense. I would still tend towards removing it, but will
> > wait to see what everybody else thinks.
>
> Yes, I am inclined to not include "fdt addr ${fdtcontroladdr};" too.
>
> >
> > Other than that, the patch looks good to me.
> >
> > Reviewed-by: Lukas Auer <lukas.a...@aisec.fraunhofer.de>
> >
>
> Reviewed-by: Bin Meng <bmeng...@gmail.com>
Applied to u-boot-riscv/master, thanks!
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
