When the MRC cache fails to save it is useful to have some debugging info
to indicate what when wrong. Add some more debug() calls.

Signed-off-by: Simon Glass <s...@chromium.org>
Reviewed-by: Bin Meng <bmeng...@gmail.com>
---

Changes in v2: None

 arch/x86/lib/mrccache.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/arch/x86/lib/mrccache.c b/arch/x86/lib/mrccache.c
index f37a732a45c..be107627b80 100644
--- a/arch/x86/lib/mrccache.c
+++ b/arch/x86/lib/mrccache.c
@@ -113,8 +113,10 @@ int mrccache_update(struct udevice *sf, struct mrc_region 
*entry,
        ulong base_addr;
        int ret;
 
-       if (!is_mrc_cache(cur))
+       if (!is_mrc_cache(cur)) {
+               debug("%s: Cache data not valid\n", __func__);
                return -EINVAL;
+       }
 
        /* Find the last used block */
        base_addr = entry->base + entry->offset;
@@ -205,17 +207,23 @@ int mrccache_get_region(struct udevice **devp, struct 
mrc_region *entry)
                return -ENOENT;
        }
 
-       if (fdtdec_get_int_array(blob, node, "memory-map", reg, 2))
+       if (fdtdec_get_int_array(blob, node, "memory-map", reg, 2)) {
+               debug("%s: Cannot find memory map\n", __func__);
                return -EINVAL;
+       }
        entry->base = reg[0];
 
        /* Find the place where we put the MRC cache */
        mrc_node = fdt_subnode_offset(blob, node, "rw-mrc-cache");
-       if (mrc_node < 0)
+       if (mrc_node < 0) {
+               debug("%s: Cannot find node\n", __func__);
                return -EPERM;
+       }
 
-       if (fdtdec_get_int_array(blob, mrc_node, "reg", reg, 2))
+       if (fdtdec_get_int_array(blob, mrc_node, "reg", reg, 2)) {
+               debug("%s: Cannot find address\n", __func__);
                return -EINVAL;
+       }
        entry->offset = reg[0];
        entry->length = reg[1];
 
-- 
2.21.0.593.g511ec345e18-goog

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to