Hi Bin Bin Meng <bmeng...@gmail.com> 於 2019年4月23日 週二 下午8:14寫道： > > Hi Rick, > > On Tue, Apr 23, 2019 at 1:47 PM Andes <ub...@andestech.com> wrote: > > > > From: Rick Chen <r...@andestech.com> > > > > commit title should read: prior_stage_fdt_address should only be used > when OF_PRIOR_STAGE is enabled
OK > > > This patch will fix prior_stage_fdt_address write failure problem, when > > AE350 was booting from flash. > > > > When AE350 was booting from falsh, prior_stage_fdt_address will be in > > flash address, we shall avoid it to be written. > > > > Signed-off-by: Rick Chen <r...@andestech.com> > > Cc: Greentime Hu <greent...@andestech.com> > > --- > > arch/riscv/cpu/start.S | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/riscv/cpu/start.S b/arch/riscv/cpu/start.S > > index d030d4a..0e672e0 100644 > > --- a/arch/riscv/cpu/start.S > > +++ b/arch/riscv/cpu/start.S > > @@ -111,7 +111,9 @@ call_board_init_f_0: > > bnez tp, secondary_hart_loop > > #endif > > > > +# if CONFIG_IS_ENABLED(OF_PRIOR_STAGE) > > la t0, prior_stage_fdt_address > > +#endif > > I think you should also surround the declaration of > prior_stage_fdt_address in arch/riscv/cpu/cpu.c with OF_PRIOR_STAGE OK I will surround it. Thanks for review Rick > > > SREG s1, 0(t0) > > > > jal board_init_f_init_reserve > > -- > > Regards, > Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
