On 11/04/2019 13:09, Anatolij Gustschin wrote: Hi Anatolij,
thanks for the heads up! > On Tue, 9 Apr 2019 23:05:11 +0200 > Anatolij Gustschin ag...@denx.de wrote: > ... >>> drivers/video/vidconsole-uclass.c | 37 >>> +++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 37 insertions(+) >> >> Applied to u-boot-video/master, thanks! > > I've dropped all applied patches of this series now, some of them > introduced dm video_ansi test error [1]. Please fix. Thanks! Hmh, good one. Didn't find an easy way to get to the bottom of this within the ut test system, so I copied the ANSI sequences out and replayed them with a custom command, inspecting the (sandbox) screen manually. Is there a canonical way to trace down those issues? Anyway, the fix for patch 2/8 is rather simple (see below), do you want to fix this up in your tree? Or shall I sent a v2? The head of my tree passes the video_ansi test now. (This patch won't apply cleanly (blame Thunderbird), but I think you get the idea...) --- a/drivers/video/vidconsole-uclass.c +++ b/drivers/video/vidconsole-uclass.c @@ -464,7 +464,7 @@ static void vidconsole_escape_char(struct udevice *dev, char ch) break; case 40 ... 47: - /* background color */ - vid_priv->bg_col_idx &= ~7; + /* background color, also mask the bold bit */ + vid_priv->bg_col_idx &= ~0xf; vid_priv->bg_col_idx |= val - 40; vid_priv->colour_bg = vid_console_color( vid_priv, vid_priv->bg_col_idx); Cheers, Andre. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot