Hi Bin, Thanks for your comments!
> -----Original Message----- > From: Bin Meng [mailto:bmeng...@gmail.com] > Sent: 2019年4月1日 11:22 > To: Z.q. Hou <zhiqiang....@nxp.com> > Cc: u-boot@lists.denx.de; albert.u.b...@aribaud.net; Priyanka Jain > <priyanka.j...@nxp.com>; York Sun <york....@nxp.com>; > sriram.d...@nxp.com; yamada.masah...@socionext.com; Prabhakar > Kushwaha <prabhakar.kushw...@nxp.com>; Mingkai Hu > <mingkai...@nxp.com>; M.h. Lian <minghuan.l...@nxp.com> > Subject: Re: [RESEND PATCHv4 7/9] armv8: lx2160a: enable PCIe support > > On Mon, Mar 25, 2019 at 10:24 AM Z.q. Hou <zhiqiang....@nxp.com> wrote: > > > > From: Hou Zhiqiang <zhiqiang....@nxp.com> > > > > Enable the PCIe Gen4 controller driver and e1000 for LX2160ARDB and > > LX2160AQDS boards. > > > > Signed-off-by: Hou Zhiqiang <zhiqiang....@nxp.com> > > --- > > V4: > > - Add PCI command support > > - Enable PCIe in more LX2160A defconfigs > > > > configs/lx2160aqds_tfa_SECURE_BOOT_defconfig | 5 +++++ > > configs/lx2160aqds_tfa_defconfig | 6 ++++++ > > configs/lx2160ardb_tfa_SECURE_BOOT_defconfig | 5 +++++ > > configs/lx2160ardb_tfa_defconfig | 6 ++++++ > > 4 files changed, 22 insertions(+) > > > > diff --git a/configs/lx2160aqds_tfa_SECURE_BOOT_defconfig > > b/configs/lx2160aqds_tfa_SECURE_BOOT_defconfig > > index 58841053ec..367502da37 100644 > > --- a/configs/lx2160aqds_tfa_SECURE_BOOT_defconfig > > +++ b/configs/lx2160aqds_tfa_SECURE_BOOT_defconfig > > @@ -56,3 +56,8 @@ CONFIG_RSA=y > > CONFIG_SPL_RSA=y > > CONFIG_RSA_SOFTWARE_EXP=y > > CONFIG_EFI_LOADER_BOUNCE_BUFFER=y > > +CONFIG_CMD_PCI=y > > +CONFIG_PCI=y > > +CONFIG_DM_PCI=y > > +CONFIG_DM_PCI_COMPAT=y > > Since this is a new feature support, can we not depend on > CONFIG_DM_PCI_COMPAT? Yes, it should not take effect, will remove it in v5. > > > +CONFIG_PCIE_LAYERSCAPE_GEN4=y > > diff --git a/configs/lx2160aqds_tfa_defconfig > > b/configs/lx2160aqds_tfa_defconfig > > index a0b86ae142..06ef830acd 100644 > > --- a/configs/lx2160aqds_tfa_defconfig > > +++ b/configs/lx2160aqds_tfa_defconfig > > @@ -51,3 +51,9 @@ CONFIG_DM_USB=y > > CONFIG_USB_XHCI_HCD=y > > CONFIG_USB_XHCI_DWC3=y > > CONFIG_EFI_LOADER_BOUNCE_BUFFER=y > > +CONFIG_CMD_PCI=y > > +CONFIG_PCI=y > > +CONFIG_DM_PCI=y > > +CONFIG_DM_PCI_COMPAT=y > > +CONFIG_PCIE_LAYERSCAPE_GEN4=y > > +CONFIG_E1000=y > > diff --git a/configs/lx2160ardb_tfa_SECURE_BOOT_defconfig > > b/configs/lx2160ardb_tfa_SECURE_BOOT_defconfig > > index f66882d6fa..4e972cc721 100644 > > --- a/configs/lx2160ardb_tfa_SECURE_BOOT_defconfig > > +++ b/configs/lx2160ardb_tfa_SECURE_BOOT_defconfig > > @@ -53,3 +53,8 @@ CONFIG_RSA=y > > CONFIG_SPL_RSA=y > > CONFIG_RSA_SOFTWARE_EXP=y > > CONFIG_EFI_LOADER_BOUNCE_BUFFER=y > > +CONFIG_CMD_PCI=y > > +CONFIG_PCI=y > > +CONFIG_DM_PCI=y > > +CONFIG_DM_PCI_COMPAT=y > > +CONFIG_PCIE_LAYERSCAPE_GEN4=y > > diff --git a/configs/lx2160ardb_tfa_defconfig > > b/configs/lx2160ardb_tfa_defconfig > > index 2dc49c7f5d..73b3b91034 100644 > > --- a/configs/lx2160ardb_tfa_defconfig > > +++ b/configs/lx2160ardb_tfa_defconfig > > @@ -51,3 +51,9 @@ CONFIG_DM_USB=y > > CONFIG_USB_XHCI_HCD=y > > CONFIG_USB_XHCI_DWC3=y > > CONFIG_EFI_LOADER_BOUNCE_BUFFER=y > > +CONFIG_CMD_PCI=y > > +CONFIG_PCI=y > > +CONFIG_DM_PCI=y > > +CONFIG_DM_PCI_COMPAT=y > > +CONFIG_PCIE_LAYERSCAPE_GEN4=y > > +CONFIG_E1000=y > > -- > > Regards, > Bin Thanks, Zhiqiang _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
