Hi Bin, Thanks a lot for your comments!
> -----Original Message----- > From: Bin Meng [mailto:bmeng...@gmail.com] > Sent: 2019年4月1日 11:22 > To: Z.q. Hou <zhiqiang....@nxp.com> > Cc: u-boot@lists.denx.de; albert.u.b...@aribaud.net; Priyanka Jain > <priyanka.j...@nxp.com>; York Sun <york....@nxp.com>; > sriram.d...@nxp.com; yamada.masah...@socionext.com; Prabhakar > Kushwaha <prabhakar.kushw...@nxp.com>; Mingkai Hu > <mingkai...@nxp.com>; M.h. Lian <minghuan.l...@nxp.com>; Xiaowei Bao > <xiaowei....@nxp.com> > Subject: Re: [RESEND PATCHv4 3/9] pci: Add PCIe Gen4 controller driver for > NXP Layerscape SoCs > > On Mon, Mar 25, 2019 at 10:24 AM Z.q. Hou <zhiqiang....@nxp.com> wrote: > > > > From: Hou Zhiqiang <zhiqiang....@nxp.com> > > > > Add PCIe Gen4 driver for the NXP Layerscape SoCs. This PCIe controller > > is based on the Mobiveil IP, which is compatible with the PCI Express™ > > Base Specification, Revision 4.0. > > > > Signed-off-by: Hou Zhiqiang <zhiqiang....@nxp.com> > > Signed-off-by: Bao Xiaowei <xiaowei....@nxp.com> > > --- > > V4: > > - No change > > > > drivers/pci/Kconfig | 8 + > > drivers/pci/Makefile | 1 + > > drivers/pci/pcie_layerscape_gen4.c | 577 > > +++++++++++++++++++++++++++++ drivers/pci/pcie_layerscape_gen4.h | > > 264 +++++++++++++ > > 4 files changed, 850 insertions(+) > > create mode 100644 drivers/pci/pcie_layerscape_gen4.c > > create mode 100644 drivers/pci/pcie_layerscape_gen4.h > > > > diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig index > > 1521885bde..2638a5a72d 100644 > > --- a/drivers/pci/Kconfig > > +++ b/drivers/pci/Kconfig > > @@ -69,6 +69,14 @@ config PCI_RCAR_GEN2 > > Renesas RCar Gen2 SoCs. The PCIe controller on RCar Gen2 is > > also used to access EHCI USB controller on the SoC. > > > > +config PCIE_LAYERSCAPE_GEN4 > > nits: should be put in the alphabetical order Yes, will fix in v5. > > > + bool "Layerscape Gen4 PCIe support" > > + depends on DM_PCI > > + help > > + Support PCIe Gen4 on NXP Layerscape SoCs, which may have > one or > > + several PCIe controllers. The PCIe controller can work in RC or > > + EP mode according to RCW[HOST_AGT_PEX] setting. > > + > > config PCI_SANDBOX > > bool "Sandbox PCI support" > > depends on SANDBOX && DM_PCI > > Reviewed-by: Bin Meng <bmeng...@gmail.com> Thanks for your review! Regards, Zhiqiang _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
