Hi Eugeniu,
On Mon, Mar 11, 2019 at 12:42 AM Eugeniu Rosca <roscaeuge...@gmail.com> wrote: > > > Hi Igor, > > On Mon, Feb 18, 2019 at 06:21:51PM +0200, Igor Opaniuk wrote: > > From: Ruslan Trofymenko <ruslan.trofyme...@linaro.org> > > > > This sub-command serves for getting the partition index from > > partition name. > > [..] > > > CMD_PART_INFO_SIZE, > > + CMD_PART_INFO_NUMBER > > IMHO 's/number/index/' (when referring to the id of a partition) would > make code and documentation more clear since 'number' can be confused > with 'count' while 'index' is unequivocal. > > Feel free to ignore it though, as the terms seem to be intermixed in > various places of Linux/U-Boot (my opinion still stands). Agree, will be fixed in v4. > The review comment also applies to other patches from this series: > - https://patchwork.ozlabs.org/patch/1044153/ ("[U-Boot,v3,2/7] disk: > part: Extend API to get partition info") > - https://patchwork.ozlabs.org/patch/1044162/ ("[U-Boot,v3,6/7] doc: > android: Add simple guide for A/B updates") > - https://patchwork.ozlabs.org/patch/1044160/ ("[U-Boot,v3,7/7] env: > am57xx: Implement A/B boot process") > > Best regards, > Eugeniu. > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
