Hi Joe, On Sun, Mar 10, 2019 at 04:51:24PM +0800, Shawn Guo wrote: > The series adds Ethernet support for Poplar board. It firstly creates > a reset driver for HiSilicon platform, then introduces higmacv300 > Ethernet driver, and finally enables Ethernet support for Poplar board. > > Changes for v3: > - Add polarity support into reset driver, so that we can drop the > hacking on gmac reset sequence from higmacv300 driver.
Does this version look good to you? Shawn > Changes for v2: > - Rename driver symbol to HIGMACV300_ETH. > - Remove the use of temp variable 'addr' in higmac_recv(). > - Simplify the return of function higmac_ofdata_to_platdata() and > higmac_probe(). > - Combine delaration and initialization for phyintf in function > higmac_ofdata_to_platdata(). > - Eliminate the MDIO read/write macros. > - Use wait_for_bit_le32() for MDIO command completion polling. > - Set up RX packet buffers in RX_FQ descriptor at initialization time, > so that we do not need to allocate/free packet buffers repeatedly. > - Inform GMAC that the RX descriptor is no longer in use in function > higmac_free_pkt(). > - Define BITS_DESC_ENA instead of using magic number 0xf. > > Shawn Guo (3): > reset: add reset driver for HiSilicon platform > net: add higmacv300 Ethernet driver for HiSilicon platform > poplar: enable Ethernet driver support > > arch/arm/dts/hi3798cv200-u-boot.dtsi | 14 + > configs/poplar_defconfig | 3 + > drivers/net/Kconfig | 9 + > drivers/net/Makefile | 1 + > drivers/net/higmacv300.c | 597 +++++++++++++++++++++++++++ > drivers/reset/Kconfig | 6 + > drivers/reset/Makefile | 1 + > drivers/reset/reset-hisilicon.c | 111 +++++ > 8 files changed, 742 insertions(+) > create mode 100644 drivers/net/higmacv300.c > create mode 100644 drivers/reset/reset-hisilicon.c > > -- > 2.18.0 > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
