On Thu, Feb 14, 2019 at 12:35:12PM +0100, Philipp Tomsich wrote:
> Tom & Thomas,
> 
> > On 14.02.2019, at 08:56, Thomas Petazzoni <thomas.petazz...@bootlin.com> 
> > wrote:
> > 
> > However, generally speaking is U-Boot interested in allowing this kind
> > of C99 variable declaration ? For example, the Linux kernel coding
> > style doesn't allow this, but perhaps U-Boot has made a difference
> > choice here.
> 
> 
> I took the opportunity to see how widespread the use of this style already
> is in U-Boot (as it will eventually creep in, now that we’ve moved to GCC6
> or newer) and there’s only a few occurences to date:
> 
> board/synopsys/hsdk/env-lib.c:        for (u32 i = 0; i < NR_CPUS; i++) {
> board/synopsys/hsdk/env-lib.c:        for (u32 i = 0; i < NR_CPUS; i++) {
> board/synopsys/hsdk/env-lib.c:        for (u32 i = 0; i < NR_CPUS; i++) {
> board/synopsys/hsdk/env-lib.c:        for (u32 i = 0; map[i].env_name; i++)
> board/synopsys/hsdk/env-lib.c:        for (u32 i = 0; map[i].env_name; i++)
> board/synopsys/hsdk/env-lib.c:        for (u32 i = 0; map[i].env_name; i++) {
> board/synopsys/hsdk/env-lib.c:        for (u32 i = 0; map[i].env_name; i++) {
> board/synopsys/hsdk/env-lib.c:        for (u32 i = 0; map[i].env_name; i++) {
> board/synopsys/hsdk/env-lib.c:        for (u32 i = 0; map[i].env_name; i++) {
> board/synopsys/hsdk/hsdk.c:   for (u32 i = 0; i < NR_CPUS; i++) {
> board/synopsys/hsdk/hsdk.c:   for (u32 i = 0; i < NR_CPUS; i++) {
> board/synopsys/hsdk/hsdk.c:   for (u32 i = 0; i < NR_CPUS; i++) {
> board/synopsys/hsdk/hsdk.c:   for (u32 i = 0; i < NR_CPUS; i++)
> board/synopsys/hsdk/hsdk.c:   for (u32 i = MASTER_CPU_ID + 1; i < NR_CPUS; 
> i++)
> board/synopsys/hsdk/hsdk.c:   for (u32 i = 0; i < NR_CPUS; i++) {
> lib/crc16.c:  for (int i = 0;  i < len;  i++)

Well, lets go with the C99 flag instead for v2, thanks again!

-- 
Tom

Attachment: signature.asc
Description: PGP signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to