Hi Detlev,
On Tuesday 27 April 2010 16:01:11 Detlev Zundel wrote:
> > This patch consolidates bootcount_{store|load} for PowerPC by
> > implementing a common version in arch/powerpc/lib/bootcount.c. This
> > code is now used by all PowerPC variants that currently have these
> > functions implemented.
> >
> > The functions now use the proper IO-accessor functions to read/write the
> > values.
> >
> > This code also supports two different bootcount versions:
> >
> > a) Use 2 seperate words (2 * 32bit) to store the bootcounter
> > b) Use only 1 word (2* 16bit) to store the bootcounter
> >
> > Version b) was already used by MPC5xxx.
> >
> > Signed-off-by: Stefan Roese <s...@denx.de>
> > Cc: Michael Zaidman <michael.zaid...@gmail.com>
> > Cc: Wolfgang Denk <w...@denx.de>
> > Cc: Kim Phillips <kim.phill...@freescale.com>
> > Cc: Anatolij Gustschin <ag...@denx.de>
>
> Cool, thanks!
>
> I have only a cosmetic suggestion - can we rename the option
> CONFIG_SYS_BOOTCOUNT_USE_32BIT to CONFIG_SYS_BOOTCOUNT_SINGLEWORD?
> According to your documentation this would describe the situation
> somewhat closer.
Right. This name is better. I'll send an updated patch soon.
> Apart from that:
>
> Acked-by: Detlev Zundel <d...@denx.de>
Thanks.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
