> On 13.02.2019, at 11:52, David Wu <david...@rock-chips.com> wrote: > > Hi philipp, > > 在 2019/2/13 下午6:47, Philipp Tomsich 写道: >>> On 13.02.2019, at 11:33, David Wu <david...@rock-chips.com> wrote: >>> >>> >>> >>> 在 2019/2/13 下午6:13, Philipp Tomsich 写道: >>>>> On 13.02.2019, at 11:10, David Wu <david...@rock-chips.com> wrote: >>>>> >>>>> Hi Philipp, >>>>> >>>>> 在 2019/2/12 下午9:54, Philipp Tomsich 写道: >>>>>>> On 12.02.2019, at 13:38, David Wu <david...@rock-chips.com> wrote: >>>>>>> >>>>>>> Hi Philipp, >>>>>>> >>>>>>> 在 2019/2/10 上午2:24, Philipp Tomsich 写道: >>>>>>>> That said, I have been fighting issues from this patchset when trying >>>>>>>> to read >>>>>>>> from devices on the i2c0 bus on a RK3399—which had me add a “simple” >>>>>>>> pinctrl device again, as pulling all the dependencies into the SPL is >>>>>>>> a pain. >>>>>>> >>>>>>> I think you can also add the simple ops if necessary. Full pinctrl >>>>>>> should only be used at the U-boot stage, or the SPL stage where the TPL >>>>>>> is available. >>>>>>> >>>>>>> For most boards about 3288, there is no need to enable pinctrl at SPL >>>>>>> stage, such as Tinker board. >>>>>> Could you check whether TPL_MAX_SIZE and SPL_MAX_SIZE are correct for >>>>>> the RK3288? If not, please submit a patch. >>>>> >>>>> It is correct, 32KB. >>>> Interesting... >>>> I wonder why the build did not fail then, if SPL became too big. >>> >>> Popmetal is okay, the SPL is too big for Tinker, i didn't test Tinker. >> If it is too big for Tinker: does the build fail or silently ignore the >> error? > build is okay, mkimage can get the error, i just build, not to mkimage for > Tinker.
This is more than enough (mkimage is part of the build for me!) I was just wondering why Heinrich ran into this problem and didn’t see a build error (even at the mkimage stage). _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
