On Sun, Apr 4, 2010 at 7:32 PM, Marek Vasut <marek.va...@gmail.com> wrote: > In case the delays were set to 10000, the MMC card on PXA27X boards (and > PXA3xx > boards) didn't initialize on first try. Increasing the delays and leaving just > those for PXA25x and 26x (that is 200000) fixes this problem.
In general, I object to board-specific #ifdefs in drivers. At the very least, change this so that the value is specified like so: #ifndef PXA_TIMEOUT_DELAY #define PXA_TIMEOUT_DELAY 10000 #endif And then override the value in the PXA27X config file. That way, when the next board comes along, and someone objects to waiting a fifth of a second between each try, but they need more than 10,000us, they can override it to a different value without doing cascading #ifdefs. Andy _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
