Am 14.01.2019 um 17:27 schrieb Tom Rini:
On Mon, Jan 14, 2019 at 04:38:24PM +0100, Simon Goldschmidt wrote:
Tom,
Am 11.12.2018 um 02:07 schrieb Simon Glass:
On Wed, 28 Nov 2018 at 13:52, Simon Goldschmidt
<simon.k.r.goldschm...@gmail.com> wrote:
SPL currently does not check uImage CRCs when loading U-Boot.
This patch adds checking the uImage CRC when SPL loads U-Boot. It does
this by reusing the existing config option SPL_CRC32_SUPPORT to allow
leaving out the CRC check on boards where the additional code size or
boot time is a problem (adding the CRC check currently adds ~1.4 kByte
to flash).
The SPL_CRC32_SUPPORT config option now gets enabled by default if SPL
support for legacy images is enabled to check the CRC on all boards
that don't actively take countermeasures.
Signed-off-by: Simon Goldschmidt <simon.k.r.goldschm...@gmail.com>
---
Changes in v2:
- added Kconfig option SPL_LEGACY_IMAGE_CRC_CHECK to enable/disable
checking CRC on legacy images
common/spl/Kconfig | 21 +++++++++++++++------
common/spl/spl.c | 30 +++++++++++++++++++++++++++++-
include/spl.h | 5 +++++
3 files changed, 49 insertions(+), 7 deletions(-)
Reviewed-by: Simon Glass <s...@chromium.org>
This is assigned to you in patchwork, any reason you did not add it for the
2019.01 release? Is there anything missing or was this just lost?
I think I might have filed this off mentally as "Did we still want to do
this?", so I'll pick it up for the next release, thanks!
Ping?
Regards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
