On Fri, Jan 25, 2019 at 03:40:35PM +0100, Jean-Jacques Hiblot wrote: > > On 15/01/2019 15:28, Tom Rini wrote: > >On Tue, Jan 08, 2019 at 06:16:31PM +0530, Faiz Abbas wrote: > > > >>With DM conversion completed, enable CONFIG_BLK for a > >>few pending TI boards. > >> > >>Signed-off-by: Faiz Abbas <faiz_ab...@ti.com> > >>Reviewed-by: Lokesh Vutla <lokeshvu...@ti.com> > >>--- > >> configs/am335x_boneblack_vboot_defconfig | 1 - > >> configs/am335x_evm_defconfig | 1 - > >> configs/am335x_hs_evm_defconfig | 1 - > >> configs/am335x_hs_evm_uart_defconfig | 1 - > >> configs/am43xx_evm_defconfig | 1 - > >> configs/am43xx_evm_qspiboot_defconfig | 1 - > >> configs/am43xx_evm_rtconly_defconfig | 1 - > >> configs/am43xx_evm_usbhost_boot_defconfig | 1 - > >> configs/am43xx_hs_evm_defconfig | 1 - > >> configs/am57xx_evm_defconfig | 1 - > >> configs/am57xx_hs_evm_defconfig | 1 - > >> configs/k2g_evm_defconfig | 1 - > >> configs/k2g_hs_evm_defconfig | 1 - > >> 13 files changed, 13 deletions(-) > >So, a problem with this patch is that we can't only enable CONFIG_BLK in > >all cases, we also need to make sure that if we have MMC we have DM_MMC > >and if we have USB we have DM_USB. This latter case is what tripped me > >up as am43xx_evm_usbhost_boot_defconfig will have a warning with this > >patch applied as SPL_USB_SUPPORT really requires CONFIG_USB_STORAGE > >support and that in turn depends on either (BLK==n && DM_USB==n) or > >(BLK==y && DM_USB==y). > > Maybe we should break this down. > > 1) k2g and am57: they already have the right options enabled. > > 2) am335x: the options are also present, although some are disabled in SPL > > 3) am43x: some configs need to be converted to DM_USB and DM_MMC first.
Yes, submitting this as a 3 or 4 part change that goes per-SoC would be good, and clear that you're also changing a bit more on am43xx. Thanks! -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
