> -----Original Message----- > From: Joe Hershberger [mailto:joe.hershber...@ni.com] > Sent: Wednesday, January 23, 2019 7:30 PM > To: Anup Patel <anup.pa...@wdc.com> > Cc: Rick Chen <r...@andestech.com>; Bin Meng <bmeng...@gmail.com>; > Joseph Hershberger <joseph.hershber...@ni.com>; Michal Simek > <mon...@monstr.eu>; Michal Simek <michal.si...@xilinx.com>; Lukas Auer > <lukas.a...@aisec.fraunhofer.de>; Masahiro Yamada > <yamada.masah...@socionext.com>; Simon Glass <s...@chromium.org>; > Palmer Dabbelt <pal...@sifive.com>; U-Boot Mailing List <u- > b...@lists.denx.de>; Alexander Graf <ag...@suse.de>; Christoph Hellwig > <h...@infradead.org>; Paul Walmsley <paul.walms...@sifive.com> > Subject: Re: [U-Boot] [PATCH v3 04/12] net: macb: Fix clk API usage for RISC- > V systems > > On Tue, Jan 22, 2019 at 10:31 PM Anup Patel <anup.pa...@wdc.com> wrote: > > > > This patch does following fixes in MACB ethernet driver for using it > > on RISC-V systems (particularly QEMU sifive_u > > machine): > > 1. asm/arch/clk.h is not available on RISC-V port so include > > it only for non-RISC-V systems. > > 2. Don't fail in macb_enable_clk() if clk_enable() returns > > -ENOSYS because we get -ENOSYS for fixed-rate clocks. > > > > Signed-off-by: Anup Patel <anup.pa...@wdc.com> > > Reviewed-by: Bin Meng <bmeng...@gmail.com> > > --- > > drivers/net/macb.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/macb.c b/drivers/net/macb.c index > > 94c89c762b..9a06b523cc 100644 > > --- a/drivers/net/macb.c > > +++ b/drivers/net/macb.c > > @@ -38,7 +38,9 @@ > > #include <linux/mii.h> > > #include <asm/io.h> > > #include <asm/dma-mapping.h> > > +#ifndef CONFIG_RISCV > > #include <asm/arch/clk.h> > > It seems much better to include an empty header than to ifdef here.
Yes, I had tried this but "make mrproper" was failing for me due to the "rm" command used in "mrproper" make target. A place-holder asm/arch/clk.h is possible only if we improve the "mrproper" make target in top-level Makefile. I will add two more patches: 1. Improve "mrproper" make target 2. Add place-holder asm/arch/clk.h for RISC-V port Regards, Anup _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
