> -----Original Message----- > From: Joe Hershberger [mailto:[email protected]] > Sent: Wednesday, January 23, 2019 7:30 PM > To: Anup Patel <[email protected]> > Cc: Rick Chen <[email protected]>; Bin Meng <[email protected]>; > Joseph Hershberger <[email protected]>; Michal Simek > <[email protected]>; Michal Simek <[email protected]>; Lukas Auer > <[email protected]>; Masahiro Yamada > <[email protected]>; Simon Glass <[email protected]>; > Palmer Dabbelt <[email protected]>; U-Boot Mailing List <u- > [email protected]>; Alexander Graf <[email protected]>; Christoph Hellwig > <[email protected]>; Paul Walmsley <[email protected]> > Subject: Re: [U-Boot] [PATCH v3 04/12] net: macb: Fix clk API usage for RISC- > V systems > > On Tue, Jan 22, 2019 at 10:31 PM Anup Patel <[email protected]> wrote: > > > > This patch does following fixes in MACB ethernet driver for using it > > on RISC-V systems (particularly QEMU sifive_u > > machine): > > 1. asm/arch/clk.h is not available on RISC-V port so include > > it only for non-RISC-V systems. > > 2. Don't fail in macb_enable_clk() if clk_enable() returns > > -ENOSYS because we get -ENOSYS for fixed-rate clocks. > > > > Signed-off-by: Anup Patel <[email protected]> > > Reviewed-by: Bin Meng <[email protected]> > > --- > > drivers/net/macb.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/macb.c b/drivers/net/macb.c index > > 94c89c762b..9a06b523cc 100644 > > --- a/drivers/net/macb.c > > +++ b/drivers/net/macb.c > > @@ -38,7 +38,9 @@ > > #include <linux/mii.h> > > #include <asm/io.h> > > #include <asm/dma-mapping.h> > > +#ifndef CONFIG_RISCV > > #include <asm/arch/clk.h> > > It seems much better to include an empty header than to ifdef here.
Yes, I had tried this but "make mrproper" was failing for me due to the "rm" command used in "mrproper" make target. A place-holder asm/arch/clk.h is possible only if we improve the "mrproper" make target in top-level Makefile. I will add two more patches: 1. Improve "mrproper" make target 2. Add place-holder asm/arch/clk.h for RISC-V port Regards, Anup _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
