Hi Kever,
> Lukasz,
>
>
> On 01/19/2019 07:34 AM, Lukasz Majewski wrote:
> > Hi David,
> >
> >> Hi Heiko,
> >>
> >> 在 2019/1/6 上午1:17, Heiko Stuebner 写道:
> >>>> diff --git a/arch/arm/mach-rockchip/rk3188-board-spl.c
> >>>> b/arch/arm/mach-rockchip/rk3188-board-spl.c index
> >>>> 3c6c3d3c09..a5e4d39cb7 100644 ---
> >>>> a/arch/arm/mach-rockchip/rk3188-board-spl.c +++
> >>>> b/arch/arm/mach-rockchip/rk3188-board-spl.c @@ -120,7 +120,7 @@
> >>>> void board_debug_uart_init(void)
> >>>> void board_init_f(ulong dummy)
> >>>> {
> >>>> - struct udevice *pinctrl, *dev;
> >>>> + struct udevice *dev;
> >>>> int ret;
> >>>>
> >>>> #define EARLY_UART
> >>>> @@ -134,10 +134,7 @@ void board_init_f(ulong dummy)
> >>>> * printascii("string");
> >>>> */
> >>>> debug_uart_init();
> >>>> - printch('s');
> >>>> - printch('p');
> >>>> - printch('l');
> >>>> - printch('\n');
> >>>> + printascii("U-Boot SPL board init");
> >>> Did you test this change?
> >>> I remember rk3188 having issues (aka hanging) when trying to print
> >>> strings through the debug uart and only printch working at all.
> >>> (Timer issue or so?) ... Not sure if this got fixed in the
> >>> meantime?
> > But you are using the debug uart for "production". Please use the
> > proper driver.
> >
> > You may either properly setup normal uart or buffer the console
> > output until the uart is configured by device model (DM).
>
> If this is U-Boot proper, I would agree with you, but I don't agree
> this opinion for using in TPL, because TPL is running in limited
> SRAM, and we may not enable DM/console for it,If I may ask - what is the limit for TPL size? Have you considered using OF_PLATDATA with some DTS converted to C structs? > DEBUG_UART is pretty > good enough and small enough for U-Boot TPL. Do you have U-boot TPL -> SPL -> U-boot proper ? > If everything works fine, you can just turn off the DEBUG_UART and get > a TPL without any debug message in production, this is acceptable just > like we > may add silent mode for both U-Boot and Kernel in production which do > not have any debug output. I see your point. > > Thanks, > - Kever > > > > > >> I don't know there was a issue, but i test it on the Radxa board > >> today, it looks okay. > >> > >> U-Boot SPL board init > >> U-Boot SPL 2019.01-rc1-00009-gdd7b9156fe (Jan 14 2019 - 19:53:50 > >> +0800) Returning to boot ROM... > >> > >> > >> U-Boot 2019.01-rc1-00009-gdd7b9156fe (Jan 14 2019 - 19:53:50 +0800) > >> > >> Model: Radxa Rock > >> DRAM: 2 GiB > >> MMC: dwmmc@10214000: 0 > >> Loading Environment from MMC... Card did not respond to voltage > >> select! *** Warning - No block device, using default environment > >> > >> In: serial@20064000 > >> Out: serial@20064000 > >> Err: serial@20064000 > >> Model: Radxa Rock > >> rockchip_dnl_key_pressed: adc_channel_single_shot fail! > >> Net: Net Initialization Skipped > >> No ethernet found. > >> Hit any key to stop autoboot: 0 > >> => > >> > >> > >> _______________________________________________ > >> U-Boot mailing list > >> U-Boot@lists.denx.de > >> https://lists.denx.de/listinfo/u-boot > > > > > > > > Best regards, > > > > Lukasz Majewski > > > > -- > > > > DENX Software Engineering GmbH, Managing Director: Wolfgang > > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, > > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > > lu...@denx.de > > > > > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de > > https://lists.denx.de/listinfo/u-boot > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de
pgpUdNIzp1o6W.pgp
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
