Hi Alexey,

Am 09.01.2019 um 09:35 schrieb Alexey Brodkin:
Hi Simon,

-----Original Message-----
From: Simon Goldschmidt [mailto:simon.k.r.goldschm...@gmail.com]
Sent: Tuesday, January 8, 2019 12:14 AM
To: Marek Vasut <ma...@denx.de>
Cc: Simon Goldschmidt <simon.k.r.goldschm...@gmail.com>; Patrice Chotard 
<patrice.chot...@st.com>;
Simon Glass <s...@chromium.org>; Anup Patel <a...@brainfault.org>; Lokesh Vutla 
<lokeshvu...@ti.com>;
Alexey Brodkin <alexey.brod...@synopsys.com>; Patrick Delaunay 
<patrick.delau...@st.com>; Marek Vasut
<marek.va...@gmail.com>; u-boot@lists.denx.de; Álvaro Fernández Rojas 
<nolt...@gmail.com>; Ryder Lee
<ryder....@mediatek.com>; Vikas Manocha <vikas.mano...@st.com>; Alexander Graf 
<ag...@suse.de>; Weijie
Gao <weijie....@mediatek.com>
Subject: [PATCH v1 3/4] serial: add an of-platdata driver for "snps,dw-apb-uart"

Add a driver for the "snps,dw-apb-uart" used in socfpga and others.

This driver is required to get OF_PLATDATA to work for socfpga.
It uses the ns16550 driver, converting the platdata from of-platdata
go the ns16550 format.

Signed-off-by: Simon Goldschmidt <simon.k.r.goldschm...@gmail.com>
---

  drivers/serial/Kconfig         | 10 ++++++++
  drivers/serial/Makefile        |  1 +
  drivers/serial/serial_dw_apb.c | 42 ++++++++++++++++++++++++++++++++++
  3 files changed, 53 insertions(+)
  create mode 100644 drivers/serial/serial_dw_apb.c

diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index b7ff2960ab..10addd3309 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -511,6 +511,16 @@ config BCM283X_PL011_SERIAL
          that supports automatic disable, so that it only gets used when
          the UART is actually muxed.

+config DESIGNWARE_SERIAL
+       bool "DesignWare UART support"
+       depends on DM_SERIAL && SPL_OF_PLATDATA

Might be a bit naïve question but why depend on SPL_OF_PLATDATA only?
What about CONFIG_OF_EMBED?

I'd happily switch my ARC boards on this driver and get rid of all
CONFIG_SYS_NS16550_xxx nonsense in include/configs/myboardname.h

I checked include/configs/socfpga_common.h again and by its using Kconfig and DM_SERIAL, there are no CONFIG_SYS_NS16550_xxx defines left (other than CONFIG_SYS_NS16550_SERIAL, which I will remove).

So it seems it's not a matter of a new driver but a matter of cleaning up the boards to use DM_SERIAL, I guess?

Regards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to