Am 09.01.19 um 09:21 schrieb Horatiu Vultur: > Hi Daniel, > > First, thank you for all the feedback. > > I have created a new patch series that will fix the issue that you > addressed bellow but the fix it would not use compatible string, because > that presume that I need to change the other pinctrl-drivers(ocelot, luton). > I was thinking if it is OK the way I have done in v3 and then create a > new patch series specific for fixing pinctrl. Similar with the issue > that I have for sysreset driver.
I didn't expect that you select the registers via compatible strings in the pinctrl driver because you effectively have three drivers and a common driver core. Your v3 variant is perfect. The compatible string method makes sense for drivers that support more than one SoC. The sysreset driver could be an example. -- - Daniel _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot