Rabin VINCENT wrote: > On Sun, Mar 28, 2010 at 07:49:15PM +0200, Tom wrote: >> Rabin Vincent wrote: >>> + /* UART2 */ >>> + nmk_gpio_af(29, GPIO_ALT_C); >>> + nmk_gpio_af(30, GPIO_ALT_C); >> Change these to immediates to logical #define's > > I've changed this in the other places you mentioned, but for these > GPIOs, I'd prefer to use the pin numbers directly. > Then add a comment to what 29 and 30 are. Tom
> Rabin > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
