On 21.12.18 22:15, Simon Glass wrote: > On Thu, 20 Dec 2018 at 18:18, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: >> >> Some boards support NVME drives. We should be able to use them as boot >> devices. >> >> NVME access requires running 'nvme scan'. >> >> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> >> --- >> include/config_distro_bootcmd.h | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> > > Reviewed-by: Simon Glass <s...@chromium.org> > > BUT > > with CONFIG_BLK we can enumerate all block devices without all of this > mess and we should be able to probe them too. > > All nvme_scan_namespace() does is probe all the devices. We could do > the same thing generically. > > So, I suggest we simplify this distro stuff to scan CONFIG_BLK and we > can drop most of the code and complexity.
I think that's a great idea. We would need some new command for that though. Something like "blk"? Given that this is bigger rework, I'll apply this patch as interim stop-gap regardless - booting from NVMe is useful today. Going forward we should then move to a new, more generic block storage access command. Alex _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
