Hi,
On Fri, 21 Dec 2018 at 01:25, Chee, Tien Fong <tien.fong.c...@intel.com> wrote:
>
> On Fri, 2018-12-14 at 14:53 +0800, tien.fong.c...@intel.com wrote:
> > From: Tien Fong Chee <tien.fong.c...@intel.com>
> >
> > Firmware loader would encounter problem if the MMC is accessed before
> > initializing it. This patch would adding the support of initializing
> > MMC before the MMC is accessed by firmware loader.
> >
> > Signed-off-by: Tien Fong Chee <tien.fong.c...@intel.com>
> > ---
> > drivers/misc/fs_loader.c | 31 +++++++++++++++++++++++++++++++
> > 1 files changed, 31 insertions(+), 0 deletions(-)
> >
> Any comment for this patch?
This should not be needed with CONFIG_DM_MMC enabled as it should be
enough to probe the mmc device. Is that right?
Regards,
Simon
>
> > diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
> > index 57a14a3..744fa46 100644
> > --- a/drivers/misc/fs_loader.c
> > +++ b/drivers/misc/fs_loader.c
> > @@ -12,6 +12,7 @@
> > #include <linux/string.h>
> > #include <mapmem.h>
> > #include <malloc.h>
> > +#include <mmc.h>
> > #include <spl.h>
> >
> > DECLARE_GLOBAL_DATA_PTR;
> > @@ -252,6 +253,36 @@ static int fs_loader_ofdata_to_platdata(struct
> > udevice *dev)
> >
> > static int fs_loader_probe(struct udevice *dev)
> > {
> > +#ifdef CONFIG_MMC
> > + int ret;
> > + struct device_platdata *plat = dev->platdata;
> > +
> > + ret = mmc_initialize(NULL);
> > + if (ret) {
> > + debug("MMC: could not initialize mmc. error: %d\n",
> > ret);
> > +
> > + return ret;
> > + }
> > +
> > + if (plat->phandlepart.phandle) {
> > + ofnode node = ofnode_get_by_phandle(plat-
> > >phandlepart.phandle);
> > +
> > + struct udevice *mmc_dev = NULL;
> > +
> > + ret = device_get_global_by_ofnode(node, &mmc_dev);
> > + if (!ret) {
> > + struct mmc *mmc = mmc_get_mmc_dev(mmc_dev);
> > +
> > + ret = mmc_init(mmc);
> > + if (ret) {
> > + debug("MMC: mmc init failed with
> > error: %d\n",
> > + ret);
> > +
> > + return ret;
> > + }
> > + }
> > + }
> > +#endif
> > return 0;
> > };
> >
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
