Hi Simon, On Thu, 13 Dec 2018 at 22:15, Simon Goldschmidt <simon.k.r.goldschm...@gmail.com> wrote: > > > > Am Fr., 14. Dez. 2018, 04:10 hat Simon Glass <s...@chromium.org> geschrieben: >> >> Hi Simon, >> >> On Thu, 13 Dec 2018 at 02:45, Simon Goldschmidt >> <simon.k.r.goldschm...@gmail.com> wrote: >> > >> > Hi Tom, >> > >> > On Tue, Dec 4, 2018 at 5:51 AM Tom Rini <tr...@konsulko.com> wrote: >> > > >> > > On Thu, Nov 29, 2018 at 06:21:11PM -0500, Tom Rini wrote: >> > > >> > > > Given that at this point the MMC subsystem itself has been migrated >> > > > along with a number of subsystem drivers, formalize a deadline for >> > > > migration. >> > > > >> > > > Reviewed-by: Simon Glass <s...@chromium.org> >> > > > Cc: Jaehoon Chung <jh80.ch...@samsung.com> >> > > > Signed-off-by: Tom Rini <tr...@konsulko.com> >> > > > Reviewed-by: Simon Goldschmidt <simon.k.r.goldschm...@gmail.com> >> > > > Reviewed-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> >> > > >> > > Applied to u-boot/master, thanks! >> > >> > I have finally found the time to test current mainline on all our >> > board configs and now I still get the warning "This board does not use >> > CONFIG_DM_MMC". Supposedly this is because I have CONFIG_BLK disabled >> > (because of size limitations: this U-Boot image runs from FPGA and >> > just configures the eMMC without loading files from it). >> > >> > Would it make sense to change the test like this: >> > >> > diff --git a/Makefile b/Makefile >> > index 0d11ff9797..41bde15b74 100644 >> > --- a/Makefile >> > +++ b/Makefile >> > @@ -920,7 +920,7 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) >> > @echo "before sending patches to the mailing list." >> > @echo "====================================================" >> > endif >> > -ifeq ($(CONFIG_MMC),y) >> > +ifeq ($(CONFIG_MMC)$(CONFIG_BLK),yy) >> > ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) >> > @echo "===================== WARNING ======================" >> > @echo "This board does not use CONFIG_DM_MMC. Please update" >> > >> > Is it intentional that CONFIG_BLK needs to be enabled? >> >> Yes it is, unless you don't actually use block devices. What is the >> goal of initing eMMC without using it? > > > We're only initializing pSLC mode in that configuration. The boot flow is via > tftp. I know this might be a rare use case but I'm more or less forced to > disable block devices because I only have ~200KiB for U-Boot when running > from FPGA.
Maybe disabling HAVE_BLOCK_DEVICE would provide a means to avoid the warning? Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
